Re: merging msvc in branch-1.11

[Peter Rosin]

Stefano Lattarini skrev 2011-11-10 11:27:
> On Tuesday 08 November 2011, Peter Rosin wrote:
>> Peter Rosin skrev 2011-11-08 21:48:
>>
>>> msvc-for-1.11 seems to work ok here. Testsuite still running though.
>>
>> And it stumbled on extra-portability2.test for similar reasons as
>> with ar-lib{3,4}.test but I'm not sure if the "sanity check" should
>> just be removed or what?
>>
>> The "sanity check" is:
>>
>> # Make sure the test is useful.
>> AUTOMAKE_fails
>>
>> but this doesn't fail since extra-portability isn't activated by -Wall.
>>
> The point of the sanity check is to ensure that the test case setup really
> causes automake to fail if `extra-portability' warnings are enabled.  And
> it's a good thing this sanity check has started to fail in msvc-for-1.11,
> because the `extra-portability2.test' has become broken there; I mean, of
> course "automake -Wall -Werror --gnits" won't trip on `extra-portability'
> warnings -- they are not enabled by `-Wall' anymore!

Of course.

> Attached is the patch I've pushed to remedy this situation.

Hmmm, I'd argue that when -Wextra-portability has been *explicitly*
specified it is wrong for it to disappear into thin air when you specify
--foreign (or one of the others). Do you happen to know if it is still
possibly to (re-)enable it by specifying -Wextra-portability after
--foreign?

>> Another snag in the testsuite is that branch-1.11:tests/ltinit.test needs
>> the below hunk (or similar) from testsuite-work in order to not fail on
>> MinGW.
>>
>> @@ -57,7 +57,7 @@ $AUTOMAKE -a
>>  cwd=`pwd`
>>  ./configure --prefix="$cwd/inst" >stdout || { cat stdout; Exit 1; }
>>  cat stdout
>> -grep '^checking.*dlopen' stdout
>> +grep '^checking.*dlfcn\.h.* no$' stdout || grep '^checking.*dlopen' stdout
>>  
>>  $MAKE
>>  $MAKE install
>>
> Will you do that or should I?

Please go ahead, this...

> Oh, and BTW, I see that `ltinit.test' is present in `maint' too, so the
> right fix is to apply the fix to `maint', and then merge `maint' into
> `branch-1.11' (and `master' as well, in fact).

...make me stay away from it. Thanks!

Cheers,
Peter