automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: fixup: make distcheck-override-infodir pass again


From: Stefano Lattarini
Subject: Re: [PATCH] tests: fixup: make distcheck-override-infodir pass again
Date: Tue, 14 Aug 2012 18:44:08 +0200

Hi Peter, thanks for the report and the fix.

On 08/14/2012 03:25 PM, Peter Rosin wrote:
>
> Ok to push this fix to maint?
> 
> Cheers,
> Peter
> 
> [Subject] tests: fixup: make distcheck-override-infodir pass again
>
I'd suggest being a little more precise:

  tests: fixup: avoid spurious failure on Cygwin for distcheck-override-infodir

> diff --git a/t/distcheck-override-infodir.sh b/t/distcheck-override-infodir.sh
> index 74f6c67..eb41a37 100755
> --- a/t/distcheck-override-infodir.sh
> +++ b/t/distcheck-override-infodir.sh
> @@ -39,7 +39,7 @@ installcheck-local:
>  END
>  
>  # Protect with leading " # " to avoid spurious maintainer-check failures.
> -sed 's/^ #//' > main.texi << 'END'
> +sed 's/^ # //' > main.texi << 'END'
>
I'd say we might be even safer and do 's/^ *# *//'.  OK?

>   # \input texinfo
>   # @setfilename main.info
>   # @settitle main
>
ACK with those two nits addressed.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]