[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: reinstate AM_PROG_MKDIR_P
From: |
Jim Meyering |
Subject: |
Re: reinstate AM_PROG_MKDIR_P |
Date: |
Fri, 26 Oct 2012 13:05:34 +0200 |
Stefano Lattarini wrote:
> On 10/25/2012 07:32 PM, Jim Meyering wrote:
>> You wrote:
>>> OK, if someone sends a patch reverting the AM_PROG_MKDIR_P removal (with a
>>> rationale in the commit message), I'll take it. But AM_PROG_MKDIR_P will
>>> be dropped in 1.14, without further "ifs" or "buts".
>>
>> Hi Stefano,
>>
>> Here's the promised patch.
>> This is relative to "master" and "make check" still passes.
>>
> Thanks. The patch will be OK to go after one nit (see below) is
> resolved.
>
> But please note that I'm going to remove AM_PROG_MKDIR_P for good in
> Automake 1.14, independently of what gettext does; so you might want
> to put some pressure on that project to accept my pending patch that
> makes it use AC_PROG_MKDIR_P instead of AM_PROG_MKDIR_P:
>
> <http://lists.gnu.org/archive/html/bug-gettext/2012-10/msg00001.html>
I suggest that you request commit privileges.
If granted, you'll be able to apply it yourself.
...
>> Subject: [PATCH] reinstate AM_PROG_MKDIR_P
>>
> Feel free to ignore this, but: what about using the "compat" prefix for
> the summary line, and giving few more details? As in
>
> compat: reinstate AM_PROG_MKDIR_P, for gettext
No trouble. Done.
...
>> * doc/automake.texi (Obsolete Macros): Restore deleted section.
>>
> Could you please restore only the entry for AM_PROG_MKDIR_P, rather
> than the entire section? Thanks.
Done, too.
> ACK with that addressed.
Pushed. Thanks for the review.