[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] aclocal: just warn if the primary local m4 dir doesn'
From: |
Pavel Raiskup |
Subject: |
Re: [PATCH v3 1/2] aclocal: just warn if the primary local m4 dir doesn't exist (don't error) |
Date: |
Mon, 18 Feb 2013 09:53:18 +0100 |
Hi Stefano, thanks for refinements! I'm ok with these patches.
> [..]
>
> See also:
> <http://lists.gnu.org/archive/html/bug-automake/2013-01/msg00115.html>
> <http://lists.gnu.org/archive/html/automake-patches/2010-02/msg00030.html>
> <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=565663>
> <https://bugzilla.redhat.com/show_bug.cgi?id=901333>
>
> * aclocal.in (SCAN_M4_DIRS_SILENT, SCAN_M4_DIRS_WARN,
> SCAN_M4_DIRS_ERROR): New constants.
This is a nit but the first line should be closed by ')' and second line
opened with '('.
> [..]
> diff --git a/THANKS b/THANKS
> index 66498d4..5c014bf 100644
> --- a/THANKS
> +++ b/THANKS
> @@ -297,6 +297,7 @@ Paul Jarc address@hidden
> Paul Lunau address@hidden
> Paul Martinolich address@hidden
> Paul Thomas address@hidden
> +Pavel Raiskup address@hidden
Thanks :).
> +$ACLOCAL -Wno-error 2>stderr \
> + && cat stderr >&2 \
> + && test $(grep -c "couldn't open directory 'not-exist'" stderr) -eq 1 \
Nice check!
Pavel