automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AM_CONDITIONAL fails with line break at the end of $2


From: Eric Blake
Subject: Re: AM_CONDITIONAL fails with line break at the end of $2
Date: Thu, 17 Jul 2014 15:49:14 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

dropping autoconf

On 07/17/2014 10:24 AM, Eric Blake wrote:
> [adding automake]
> 
> On 07/17/2014 10:00 AM, Dimitrios Apostolou wrote:
> 
>> --- cond.m4  2014-07-17 17:46:37.741723897 +0200
>> +++ cond.2.m4        2014-07-17 17:50:43.456076469 +0200
>> @@ -13,17 +13,18 @@
>>  [AC_PREREQ([2.52])dnl
>>   m4_if([$1], [TRUE],  [AC_FATAL([$0: invalid condition: $1])],
>>         [$1], [FALSE], [AC_FATAL([$0: invalid condition: $1])])dnl
>>  AC_SUBST([$1_TRUE])dnl
>>  AC_SUBST([$1_FALSE])dnl
>>  _AM_SUBST_NOTMAKE([$1_TRUE])dnl
>>  _AM_SUBST_NOTMAKE([$1_FALSE])dnl
>>  m4_define([_AM_COND_VALUE_$1], [$2])dnl
>> -if $2; then
>> +if $2
>> +then
>>    $1_TRUE=
>>    $1_FALSE='#'
>>  else
>>    $1_TRUE='#'
>>    $1_FALSE=
>>  fi
>>  AC_CONFIG_COMMANDS_PRE(
>>  [if test -z "${$1_TRUE}" && test -z "${$1_FALSE}"; then
> 

This patch looks correct for automake, especially given that I just
pushed a similar patch to autoconf's AS_IF.  Alas, I don't trust myself
to push it to all the correct automake branches, so I'm hoping a
maintainer will step in here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]