[avr-libc-commit] [2265] bug #32773: stdiodemo source code is broken

[Joerg Wunsch]

Revision: 2265
          http://svn.sv.gnu.org/viewvc/?view=rev&root=avr-libc&revision=2265
Author:   joerg_wunsch
Date:     2011-12-28 21:28:29 +0000 (Wed, 28 Dec 2011)
Log Message:
-----------
bug #32773: stdiodemo source code is broken
* doc/examples/stdiodemo/lcd.c: pass an argument when calling
hd44780_wait_ready()
* doc/examples/stdiodemo/Makefile: don't attempt to build the
EEPROM load files, as there are now EEPROM data

Ticket Links:
------------
    http://savannah.gnu.org/bugs/?32773

Modified Paths:
--------------
    trunk/avr-libc/ChangeLog
    trunk/avr-libc/NEWS
    trunk/avr-libc/doc/examples/stdiodemo/Makefile
    trunk/avr-libc/doc/examples/stdiodemo/lcd.c

Modified: trunk/avr-libc/ChangeLog
===================================================================
--- trunk/avr-libc/ChangeLog    2011-12-25 01:16:55 UTC (rev 2264)
+++ trunk/avr-libc/ChangeLog    2011-12-28 21:28:29 UTC (rev 2265)
@@ -1,3 +1,11 @@
+2011-12-28  Joerg Wunsch <address@hidden>
+
+       bug #32773: stdiodemo source code is broken
+       * doc/examples/stdiodemo/lcd.c: pass an argument when calling
+       hd44780_wait_ready()
+       * doc/examples/stdiodemo/Makefile: don't attempt to build the
+       EEPROM load files, as there are now EEPROM data
+
 2011-12-25  Dmitry Xmelkov  <address@hidden>
 
        Fix for bug #34514: misspelled in math.h

Modified: trunk/avr-libc/NEWS
===================================================================
--- trunk/avr-libc/NEWS 2011-12-25 01:16:55 UTC (rev 2264)
+++ trunk/avr-libc/NEWS 2011-12-28 21:28:29 UTC (rev 2265)
@@ -20,6 +20,7 @@
   [#34514] misspelled in math.h
   [#35020] stdint.h: signed types need explicit "signed"
   [#35093] strlcat_P fails for some destinations
+  [#32773] stdiodemo source code is broken
   [no-id]  New names for CLKSTA/CLKSEL0/1 for AT90USB82/162
   system when power_all_disable() is used
   [no-id]  util/delay.h would not compile with -ffreestanding

Modified: trunk/avr-libc/doc/examples/stdiodemo/Makefile
===================================================================
--- trunk/avr-libc/doc/examples/stdiodemo/Makefile      2011-12-25 01:16:55 UTC 
(rev 2264)
+++ trunk/avr-libc/doc/examples/stdiodemo/Makefile      2011-12-28 21:28:29 UTC 
(rev 2265)
@@ -16,7 +16,8 @@
 OBJCOPY        = avr-objcopy
 OBJDUMP        = avr-objdump
 
-all: $(PRG).elf lst text eeprom
+#all: $(PRG).elf lst text eeprom
+all: $(PRG).elf lst text
 
 $(PRG).elf: $(OBJ)
        $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(LIBS)

Modified: trunk/avr-libc/doc/examples/stdiodemo/lcd.c
===================================================================
--- trunk/avr-libc/doc/examples/stdiodemo/lcd.c 2011-12-25 01:16:55 UTC (rev 
2264)
+++ trunk/avr-libc/doc/examples/stdiodemo/lcd.c 2011-12-28 21:28:29 UTC (rev 
2265)
@@ -38,20 +38,20 @@
    * Clear the display.
    */
   hd44780_outcmd(HD44780_CLR);
-  hd44780_wait_ready();
+  hd44780_wait_ready(true);
 
   /*
    * Entry mode: auto-increment address counter, no display shift in
    * effect.
    */
   hd44780_outcmd(HD44780_ENTMODE(1, 0));
-  hd44780_wait_ready();
+  hd44780_wait_ready(false);
 
   /*
    * Enable display, activate non-blinking cursor.
    */
   hd44780_outcmd(HD44780_DISPCTL(1, 1, 0));
-  hd44780_wait_ready();
+  hd44780_wait_ready(false);
 }
 
 /*
@@ -68,11 +68,11 @@
       /*
        * First character after newline, clear display and home cursor.
        */
-      hd44780_wait_ready();
+      hd44780_wait_ready(false);
       hd44780_outcmd(HD44780_CLR);
-      hd44780_wait_ready();
+      hd44780_wait_ready(false);
       hd44780_outcmd(HD44780_HOME);
-      hd44780_wait_ready();
+      hd44780_wait_ready(true);
       hd44780_outcmd(HD44780_DDADDR(0));
 
       nl_seen = false;
@@ -83,7 +83,7 @@
     }
   else
     {
-      hd44780_wait_ready();
+      hd44780_wait_ready(false);
       hd44780_outdata(c);
     }