avr-libc-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [avr-libc-dev] Why include <ina90.h> from <avr/pgmspace.h>?


From: Theodore A. Roth
Subject: Re: [avr-libc-dev] Why include <ina90.h> from <avr/pgmspace.h>?
Date: Mon, 7 Oct 2002 13:36:12 -0700 (PDT)

On Mon, 7 Oct 2002, Joerg Wunsch wrote:

:) As E. Weddington wrote:
:)
:) > On 6 Oct 2002 at 23:54, Joerg Wunsch wrote:
:) >
:) > I only have one nit, having to do with underscores. I've seen where
:) > other people have used _LPM(). With these changes, it will be
:) > __LPM(), but you include the definition with 1 underscore in ina90.h.
:)
:) Well, then those people are actually using INA90 compatibility, IMHO.
:)
:) I vaguely remember that names with one leading underscore are
:) something special and should not normally be used/exported.  Well,
:) it's even possible they are in the application's domain, i. e. it
:) is valid for application code to define their own _LPM object.

I'd really like to know definitively what the conventions for using a
single and a double underscore in the library are. I for one have been
utterly confused on more than one occasion. Seems to me that user
application code should not be relying or using anything from the library
that starts with an underscore. This gives the developers the ability to
change the "behind the scnes" implementation with out breaking users code
(assuming the user did the right thing). I'd like to see a note in the
docs explaining this.

Ted Roth

:)
:) > I don't necessarily think that the "1 underscore definition" would be
:) > used exclusively with compatibility code, i.e. other people have used
:) > _LPM() because of reasons not having to do with IAR compatibility.
:)
:) They should use __lpm_inline() then, or maybe PRG_RDB().





reply via email to

[Prev in Thread] Current Thread [Next in Thread]