avr-libc-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [avr-libc-dev] [bugs #12033] macros.inc need to be protected from mu


From: Joerg Wunsch
Subject: Re: [avr-libc-dev] [bugs #12033] macros.inc need to be protected from multiple inclusion.
Date: Sat, 19 Feb 2005 23:21:50 +0100
User-agent: Mutt/1.4.2.1i

As E. Weddington wrote:

> But surely making macros.inc idempotent is useful too?

I'd even do the opposite: fplib.inc used to have the #ifdef magic on
top, I'm inclined to remove it.

As these files are deemed to be internal to the library (and not
intented for use by end-users), I'd consider it a bug if someone wants
to include one of them more than once.

I'd rather like to untangle all that macro spaghetti some day.
Ideally, there would be no more than a single central header file
needed for the entire library (plus perhaps local files, as we have in
stdlib_private.h etc.).  It always annoyed me how complicated it's
right now to see which register actually belongs to fplib's rA2, or
rAE etc.

If we think some of the macros there are good for users, too, we could
always put them into an exported header file.

-- 
cheers, J"org               .-.-.   --... ...--   -.. .  DL8DTL

http://www.sax.de/~joerg/                        NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]