Re: [avr-libc-dev] No guard in macros.inc

[Joerg Wunsch]

As Curtis Maloney wrote:

>       A cursory look showed this was because
> libc/pmstring/strlcat_P.S was including gasava.inc and then
> macros.inc.  However, gasava.inc also includes macros.inc.
> Normally, this isn't a problem, because it's common practice to put
> guard #ifndef's around an include, right?

See bug report #12033, and the discussion following it (in the list
archives).

IMHO, adding the guard would only mask the actual problem, so I'd
like to avoid it.  You can do it locally as a workaround to get your
compile done, of course.

I already started to clean up the mess, but have yet to commit the
changes to CVS.  (Cleaning up libm/fplib was much more work than the
few broken files under libc/.)

Ideally, only one global include file should be needed, perhaps
assisted by a local include file (like in fplib).

>       Not quite as perplexing as why avr-libc doesn't appear to be
>       building any crt* libs for mega chips... or is that a gcc-4.0
>       thing?

GCC 4.x and/or recent binutils.  The duplicate definitions have been
silently accepted before, that's why nobody noticed the problem
earlier.

-- 
cheers, J"org               .-.-.   --... ...--   -.. .  DL8DTL

http://www.sax.de/~joerg/                        NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)