[avr-libc-dev] [bug #23032] Define PORTxn, PINxn, DDxn bit names in iomxx4.h.

[Joerg Wunsch]

Follow-up Comment #1, bug #23032 (project avr-libc):

Hmm, are you sure?

I see PORTxn, DDRxn, and PINxn bit names /are/ defined in
avr/iom1284p.h.  However, the "generic" bit names (Pxn) are
not defined for that device.  They should probably be
supplied through avr/portpins.h.  However, the logic there
is just the opposite of what would be needed: they assume
the device's header file defines whatever Pxn bits are
applicable for each device, and then conditionally derive
PORTxn names from those.

This should probably turned around: make avr/portpins.h
define Pxn based on the presence of PORTxn.  Alas, this
requires to rewrite all the existing device header files.

Another option would be to extend avr/portpins.h like:

#if defined(PORTA0) && !defined(PA0)
#  define PA0 PORTA0
#endif

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?23032>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/