[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[avrdude-dev] Cleaning up of avr910.c
From: |
Jan-Hinnerk Reichert |
Subject: |
[avrdude-dev] Cleaning up of avr910.c |
Date: |
Mon, 8 Dec 2003 14:25:13 +0100 |
User-agent: |
KMail/1.5.1 |
Hi all,
since we have a little time without CVS archive, I thought we could do
discussion about further cleanups.
I don't want any of changes suggested to below to go in before the
release. They are either cosmetic changes or cleanups.
--------------------------
/* These two defines are only for debugging. Will remove them once it
starts
working. */
#define show_func_info() \
fprintf(stderr, "%s: line %d: called %s()\n", \
__FILE__, __LINE__, __FUNCTION__)
#define no_show_func_info()
-------------------------
So, can we remove them now?
In avr910_write_setup() there is a strange workaround form Ted.
Does anyone know if it is still needed or on which programmer firmware
this was neccessary.
I also believe that sending "y" here is not good, since it is
specified to have an argument. However, the AVR910 returns an error
and doesn't get the argument ;-(
Now, the cosmetic stuff. IMHO, there is too much output when using the
AVR910.
I don't want to see a list of all supported chips every time I use
avrdude. IMHO, it should only be done if no chip is selected or if
chip is not supported (or perhaps if verbose is set to some value).
IMHO, a progress indicator for reading signature-bits is confusing,
because I haven't requested the read.
/Jan-Hinnerk
- [avrdude-dev] Cleaning up of avr910.c,
Jan-Hinnerk Reichert <=
- Re: [avrdude-dev] Cleaning up of avr910.c, E. Weddington, 2003/12/08
- Re: [avrdude-dev] Cleaning up of avr910.c, Jan-Hinnerk Reichert, 2003/12/08
- Re: [avrdude-dev] Cleaning up of avr910.c, E. Weddington, 2003/12/08
- Re: [avrdude-dev] Cleaning up of avr910.c, Jan-Hinnerk Reichert, 2003/12/09
- Re: [avrdude-dev] Cleaning up of avr910.c, E. Weddington, 2003/12/09
- RE: [avrdude-dev] Cleaning up of avr910.c, Alex Shepherd, 2003/12/09
- Re: [avrdude-dev] Cleaning up of avr910.c, Jan-Hinnerk Reichert, 2003/12/09
- Re: [avrdude-dev] Cleaning up of avr910.c, Jan-Hinnerk Reichert, 2003/12/09
- Re: [avrdude-dev] Cleaning up of avr910.c, Jan-Hinnerk Reichert, 2003/12/10
Re: [avrdude-dev] Cleaning up of avr910.c, Theodore A. Roth, 2003/12/08