Re: [avrdude-dev] [patch] fmt_autodetect() and binary files

[E. Weddington]

Theodore A. Roth wrote:

> On Mon, 4 Oct 2004, E. Weddington wrote:
>
>  
>
> > Theodore A. Roth wrote:
> >
> >    
> >
> > > Hi,
> > >
> > > I was just looking over the fmt_autodetect() function. When checking for
> > > a binary file, it is possible (although unlikely) that ever byte in the
> > > file has value < 128.
> > >
> > > Wouldn't it make sense to just not even check for binary files? Just
> > > check for recognizable format (ihex, srec, etc.) and if nothing is
> > > found, just default to binary (and issue a warning).
> > >
> > > I believe this is what bfd does and it seems to work well enough when we
> > > use it with avarice.
> > >
> > > Attached is a patch which should make all reads/writes via fileio.c be
> > > binary and changes the above noted behaviour.
> > >
> > > Can someone on a windows box try this to see if I borked anything? Does
> > > it fix the mangled binary upload problem?
> > >
> > >      
> > I noticed that this patch hasn't been applied to avrdude CVS yet.
> >
> > Are there any remaining issues for this?
> >    
>
> I don't remeber ever getting confirmation that this actually fixed the
> original problem (which I don't even completely recall now).
>  

True. But, isn't it correct that this patch does the Right Thing anyway? 
And shouldn't it be applied anyway? It gets rid of the #ifdef for 
Windows, and always opens in binary format no matter what the platform, 
and defaults to binary if no format is detectable, etc.

Eric