[avrdude-dev] [bug #35265] Findings reported by cppcheck

[Joerg Wunsch]

Follow-up Comment #4, bug #35265 (project avrdude):

> I agree about the new implementation file.

With one exception though: avrdude.c is just too generic a
name.  That name should probably be the name of the main
(CLI) file (rather than main.c).

My suggestion is to name it util.c or such.

avrdude.h should simply combine the exported interfaces
(by libavrdude.a) from _all_ the existing header files.  The
current header file structure is a nuisance for anyone who
wants to use the library.  If there are library-internal
interfaces that are not supposed to be exported (so they
could be easily changed between library versions), they could
go into a second header file that is only used to build the
library itself, but not going to be installed even in case
we once install the library itself.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?35265>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/