axiom-developer
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Axiom-developer] PATCH : retrieval of Stream from a KAF file


From: Waldek Hebisch
Subject: Re: [Axiom-developer] PATCH : retrieval of Stream from a KAF file
Date: Fri, 17 Nov 2006 21:50:03 +0100 (CET)

> Hello,
> 
> Here is a small patch that fixes the incorrect retrieval of some Streams
> from a KAF file. It replaces 'EQ' by 'EQUAL' for comparisons of strings.
> There are some other unmodified uses of EQ in this file. They need
> further investigations and in particular I need to look at what I
> consider a big issue : equality with object of type 'Any' (I postponed
> my work on Stream).
> 
> --- src/algebra/stream.spad.pamphlet.old      2006-11-17 16:59:13.000000000
> +0100
> +++ src/algebra/stream.spad.pamphlet  2006-11-17 17:24:39.000000000 +0100
> @@ -647,8 +647,8 @@
>  
>      Rep := Record(firstElt: S, restOfStream: %)
>  
> -    explicitlyEmpty? x == EQ(frst x,NullStream)$Lisp
> -    lazy? x            == EQ(frst x,NonNullStream)$Lisp
> +    explicitlyEmpty? x == EQUAL(frst x,NullStream)$Lisp
> +    lazy? x            == EQUAL(frst x,NonNullStream)$Lisp
>  
>  --% signatures of local functions
>  
> 

That looks strange for me. NullStream and NonNullStream should be
unique objects, so I would probably turn them into symbols.  Your
change would make a one element list:

 ["NonNullStream"]

into invalid stream (I think such list is a valid stream od strings).

-- 
                              Waldek Hebisch
address@hidden 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]