[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: how to pass arguments to bbdb-create-internal
From: |
Gijs Hillenius |
Subject: |
Re: how to pass arguments to bbdb-create-internal |
Date: |
Tue, 09 Jan 2018 20:49:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
On 9 Jan 2018, Roland Winkler wrote:
> On Tue Jan 9 2018 Gijs Hillenius wrote:
>> I'd like to understand how to use bbdb-create-internal, part of
>> bbdb-com.el. This is part of my tracking down a change or bug that
>> prevents me from using bbdb-csv-import.el (from 2014).
>
> ...Strange: Recently I did change the calling sequence of
> bbdb-create-internal because this function became messier and
> messier each time more fields were added to BBDB records. So now
> the calling sequence relies on keywords that will help with any
> further changes that might be required one day in the future.
>
> Yet I remember I did not make the new code backward-compatible
> because I thought the old code was somehow inherently broken anyway.
> This would not affect BBDB itself because it does not use this
> function. Yet when I look today at the old code for
> bbdb-create-internal (from before the switch to keyword args) I do
> not understand anymore what could have been broken, and your code
> seems to have been a happy user of this function.
>
> Therefore:
>
> - I recommend that any code using bbdb-create-internal should be
> upgraded to use the new calling sequence
>
> - Nonetheless I'll add code to support the old calling sequence
> (combined with a warning message).
>
Thanks!
So bbdb-create-internal /did/ change. I had been looking at elpa-git for
recent changes, http://git.savannah.gnu.org/ but I bet I was in the
wrong place, coz I found nothing...
I'll study what is changed and see if I can help Ian Kelling, the
original author of bbdb-csv-import.el.