[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: Patch for Build under MSW + MSYS2

From: Vincent Belaïche
Subject: RE: Patch for Build under MSW + MSYS2
Date: Wed, 7 Mar 2018 04:03:13 +0000

Answers below…

De : Roland Winkler <address@hidden>
Envoyé : dimanche 18 février 2018 04:50
À : Vincent Belaïche
Cc : address@hidden
Objet : RE: Patch for Build under MSW + MSYS2 
>On Sun Feb 11 2018 Vincent Belaïche wrote:
>> Here are the answers to the two points that you raise:
>> > - Why is it necessary in a cygwin environment to call cygpath at
>> >  this place?
>I am sorry, you misunderstood:
>I was not requesting more explanations to be posted on this list but
>some brief explanations becoming part of the patch.  So if one day
>in the future someone stumbles across these lines in and
>knowing as little about these things as I do, he or she might find
>some guidance to understand the code.
>Yet with this thread having grown to this point, a link to this
>thread on the GNU list server should be sufficient.  I guess this is
>one of the advantages of the new mailing list: everything will be
OK, done I revised the patch to add a link to this thread.
>Yet also one technical question: do you need the square brackets in
>the sed regexp?  I do not see an alternative anymore in the revised
You are fully right, the only advantage of the [...] is that it saves
one level of \ escaping. But that makes the code less clear IMHO.
Also, since there is no longer any alternative, we don't need any longer
the \(...\) grouping and \1 recall in the replacement. We can directly
just replace \ by \\.
I did these changes, please find the revised patch attached.
Thank you for your great patience.

Attachment: patch-abspath-4.diff
Description: patch-abspath-4.diff

reply via email to

[Prev in Thread] Current Thread [Next in Thread]