[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Bison patches to avoid GCC 3.2 warnings on Solaris 8.
From: |
Paul Eggert |
Subject: |
Bison patches to avoid GCC 3.2 warnings on Solaris 8. |
Date: |
Sat, 19 Oct 2002 23:02:40 -0700 (PDT) |
configure --enable-gcc-warnings caught some minor problems, and I
installed these fixes. I suppose the xstrdup might cause a memory
leak, but it's a minor one.
2002-10-19 Paul Eggert <address@hidden>
* src/muscle_tab.c (muscle_pair_list_grow): Rename locals to
avoid confusion with similarly-named more-global.
* src/output.c (prepare): Use xstrdup to convert char const *
to char *, to avoid GCC warning.
Index: muscle_tab.c
===================================================================
RCS file: /cvsroot/bison/bison/src/muscle_tab.c,v
retrieving revision 1.21
retrieving revision 1.22
diff -p -u -r1.21 -r1.22
--- muscle_tab.c 19 Oct 2002 14:38:06 -0000 1.21
+++ muscle_tab.c 20 Oct 2002 05:47:09 -0000 1.22
@@ -173,12 +173,12 @@ muscle_grow (const char *key, const char
void muscle_pair_list_grow (const char *muscle,
const char *a1, const char *a2)
{
- char *value;
+ char *val;
obstack_fgrow2 (&muscle_obstack, "[[[%s]], [[%s]]]", a1, a2);
obstack_1grow (&muscle_obstack, 0);
- value = obstack_finish (&muscle_obstack);
- muscle_grow (muscle, value, ",\n");
- obstack_free (&muscle_obstack, value);
+ val = obstack_finish (&muscle_obstack);
+ muscle_grow (muscle, val, ",\n");
+ obstack_free (&muscle_obstack, val);
}
/*-------------------------------.
Index: output.c
===================================================================
RCS file: /cvsroot/bison/bison/src/output.c,v
retrieving revision 1.196
retrieving revision 1.197
diff -p -u -r1.196 -r1.197
--- output.c 19 Oct 2002 14:38:06 -0000 1.196
+++ output.c 20 Oct 2002 06:01:07 -0000 1.197
@@ -306,9 +306,9 @@ prepare_states (void)
-/*----------------------------------.
-| Output the user actions to OOUT. |
-`----------------------------------*/
+/*---------------------------------.
+| Output the user actions to OUT. |
+`---------------------------------*/
static void
user_actions_output (FILE *out)
@@ -620,7 +620,7 @@ prepare (void)
}
/* Parse the skeleton file and output the needed parsers. */
- muscle_insert ("skeleton", skeleton);
+ muscle_insert ("skeleton", xstrdup (skeleton));
}
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Bison patches to avoid GCC 3.2 warnings on Solaris 8.,
Paul Eggert <=