bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

removed fflush calls in Bison


From: Paul Eggert
Subject: removed fflush calls in Bison
Date: Sat, 28 Dec 2002 17:25:01 -0800 (PST)

I installed this:

2002-12-28  Paul Eggert  <address@hidden>

        * src/complain.c (warn_at, warn, complain_at, complain, fatal_at,
        fatal): Don't invoke fflush; it's not needed and it might even be
        harmful for stdout, as stdout might not be open.
        * src/reduce.c (reduce_print): Likewise.

Index: src/complain.c
===================================================================
RCS file: /cvsroot/bison/bison/src/complain.c,v
retrieving revision 1.19
diff -p -u -r1.19 complain.c
--- src/complain.c      11 Dec 2002 06:23:40 -0000      1.19
+++ src/complain.c      29 Dec 2002 01:17:40 -0000
@@ -74,7 +74,6 @@ warn_at (location loc, const char *messa
 {
   va_list args;
 
-  fflush (stdout);
   location_print (stderr, loc);
   fputs (": ", stderr);
   fputs (_("warning: "), stderr);
@@ -85,7 +84,6 @@ warn_at (location loc, const char *messa
 
   warning_issued = true;
   putc ('\n', stderr);
-  fflush (stderr);
 }
 
 void
@@ -93,7 +91,6 @@ warn (const char *message, ...)
 {
   va_list args;
 
-  fflush (stdout);
   fprintf (stderr, "%s: %s", current_file ? current_file : program_name, 
_("warning: "));
 
   va_start (args, message);
@@ -102,7 +99,6 @@ warn (const char *message, ...)
 
   warning_issued = true;
   putc ('\n', stderr);
-  fflush (stderr);
 }
 
 /*-----------------------------------------------------------.
@@ -114,7 +110,6 @@ complain_at (location loc, const char *m
 {
   va_list args;
 
-  fflush (stdout);
   location_print (stderr, loc);
   fputs (": ", stderr);
 
@@ -124,7 +119,6 @@ complain_at (location loc, const char *m
 
   complaint_issued = true;
   putc ('\n', stderr);
-  fflush (stderr);
 }
 
 void
@@ -132,7 +126,6 @@ complain (const char *message, ...)
 {
   va_list args;
 
-  fflush (stdout);
   fprintf (stderr, "%s: ", current_file ? current_file : program_name);
 
   va_start (args, message);
@@ -141,7 +134,6 @@ complain (const char *message, ...)
 
   complaint_issued = true;
   putc ('\n', stderr);
-  fflush (stderr);
 }
 
 /*-------------------------------------------------.
@@ -153,7 +145,6 @@ fatal_at (location loc, const char *mess
 {
   va_list args;
 
-  fflush (stdout);
   location_print (stderr, loc);
   fputs (": ", stderr);
   fputs (_("fatal error: "), stderr);
@@ -162,7 +153,6 @@ fatal_at (location loc, const char *mess
   vfprintf (stderr, message, args);
   va_end (args);
   putc ('\n', stderr);
-  fflush (stderr);
   exit (EXIT_FAILURE);
 }
 
@@ -171,7 +161,6 @@ fatal (const char *message, ...)
 {
   va_list args;
 
-  fflush (stdout);
   fprintf (stderr, "%s: ", current_file ? current_file : program_name);
 
   fputs (_("fatal error: "), stderr);
@@ -180,6 +169,5 @@ fatal (const char *message, ...)
   vfprintf (stderr, message, args);
   va_end (args);
   putc ('\n', stderr);
-  fflush (stderr);
   exit (EXIT_FAILURE);
 }
Index: src/reduce.c
===================================================================
RCS file: /cvsroot/bison/bison/src/reduce.c,v
retrieving revision 1.80
diff -p -u -r1.80 reduce.c
--- src/reduce.c        13 Dec 2002 08:33:27 -0000      1.80
+++ src/reduce.c        29 Dec 2002 01:17:41 -0000
@@ -407,7 +407,6 @@ reduce_print (void)
                               nuseless_productions),
             nuseless_productions);
   fprintf (stderr, "\n");
-  fflush (stderr);
 }
 
 void



reply via email to

[Prev in Thread] Current Thread [Next in Thread]