Re: Valgrind and Bison memory leaks

[Joel E. Denny]

On Thu, 9 Nov 2006, Joel E. Denny wrote:

> On Wed, 8 Nov 2006, Joel E. Denny wrote:
> 
> > On Wed, 8 Nov 2006, Paul Eggert wrote:
> > 
> > > OK, I reviewed that patch and installed the following
> > > slightly-different one.  The main thing was that funny union, which
> > > confused me, and so I replaced it with a char const * value and a char
> > > * storage pointer (which might be null, but can be freed).
> > 
> > Thanks, I'll look it over later today.
> 
> I commited the following to address a few minor issues.

I committed another tweak.

Also, it seems that our AT_CHECK overexpands $1 before checking if it 
begins with `bison'.  I'm not sure what to do about it or if it really 
even matters.

Index: ChangeLog
===================================================================
RCS file: /sources/bison/bison/ChangeLog,v
retrieving revision 1.1604
diff -p -u -r1.1604 ChangeLog
--- ChangeLog   10 Nov 2006 06:11:20 -0000      1.1604
+++ ChangeLog   11 Nov 2006 03:52:44 -0000
@@ -1,5 +1,7 @@
 2006-11-10  Joel E. Denny  <address@hidden>
 
+       * tests/testsuite.at (AT_CHECK): Don't miss an exit value of 0 because
+       it was double-quoted.
        * src/Makefile.am (YACC): Use --warnings=all,error so that Bison's own
        grammar is maintained with Bison's highest standards.
        * src/getargs.c: Fix some typos in Doxygen comments.
Index: tests/testsuite.at
===================================================================
RCS file: /sources/bison/bison/tests/testsuite.at,v
retrieving revision 1.30
diff -p -u -r1.30 testsuite.at
--- tests/testsuite.at  9 Nov 2006 18:17:05 -0000       1.30
+++ tests/testsuite.at  11 Nov 2006 03:52:44 -0000
@@ -25,7 +25,7 @@ m4_pushdef([ORIGINAL_AT_CHECK], m4_defn(
 m4_pushdef([AT_CHECK],
 [ORIGINAL_AT_CHECK(
    m4_if(m4_quote(m4_substr(m4_quote($1), 0, 5)), [bison],
-        m4_if([$2], [0], [], [$2], [], [],
+        m4_if(m4_quote($2), [0], [], m4_quote($2), [], [],
               [[VALGRIND_OPTS="$VALGRIND_OPTS --leak-check=summary 
--show-reachable=no"; export VALGRIND_OPTS; ]]))$@)])
 
 # Testing resistance to user bugs.