Re: outdated m4sugar

[Joel E. Denny]

On Tue, 15 Jul 2008, Eric Blake wrote:

> According to Joel E. Denny on 7/15/2008 1:40 AM:
> | * data/m4sugar/m4sugar.m4 (m4_symbols): Rename from either symbols or
> | m4symbols, depending on which is already defined.
> 
> Here, I'd copy this section from the recent autoconf patch (changeword is

> | (m4_wrap): Eliminate by moving wrapped code, which dealt with cleaning
> | up the diversion stack, to...
> | * data/cleanup.m4: ... this new file.
> 
> Again, rather than creating a new file, I'd copy what autoconf does (it

> Or all three.  Would you like me to propose a patch?

Sure!

> | * src/output.c (output_skeleton): For the m4 invocation, pass
> | ../data/cleanup.m4, pass -dV first because it may become
> | position-independent, and unset POSIXLY_CORRECT so Bison's skeletons
> 
> s/in\(dependent\)/$1/

Oops.

> | +# Bison pops KILL in ../close.m4.
> 
> If you keep cleanup.m4 rather than syncing from autoconf, then this is a typo.

Oops again.  But, yes, this will go away.

> | +     FIXME: A user might set POSIXLY_CORRECT to affect processes run from
> | +     macros like m4_sycmd in a custom skeleton.  For now, Bison makes no
> 
> s/m4_sycmd/m4_syscmd/

It was one of those days.

> | +  unsetenv ("POSIXLY_CORRECT");
> 
> Good comment.  But now you need to do 'gnulib-tool --import unsetenv'.

Ok, I don't mess with gnulib much.  If I put unsetenv in gnulib_modules in 
bootstrap.conf, then lib/unsetenv.c is created but not lib/unsetenv.o.  
I'm out of time.  Does this mean unsetenv isn't needed on my platform, or 
does this mean I'm not doing this right?

So, later today, I'll rewrite and push my patch with the above 
corrections, but I'll omit the changes to m4sugar.m4, and I'll drop 
cleanup.m4.  Thus, it'll only have the -dV and POSIXLY_CORRECT fixes.  I 
assume your patch will then take care of m4sugar.m4 and m4_wrap.  Does 
this sound reasonable?

Thanks for the review!