bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make gnulib a submodule


From: Joel E. Denny
Subject: Re: [PATCH] Make gnulib a submodule
Date: Wed, 29 Oct 2008 10:42:55 -0400 (EDT)

On Wed, 29 Oct 2008, Akim Demaille wrote:

> - determinism
>   in the past, several projects, including Bison, got
>   bitten because of interface changes or bugs in GNU Lib.
>   The problem is that it then happens for some people,
>   those who just run ./bootstrap.
> 
>   Now we have a fixed version of GNU Lib, and checking
>   out Bison will always give the same version of it.
>   Unless we upgrade it, via a commit.

That sounds great... mostly for the sake of developer communication.

> - resources
>   In my environment, especially because of our build farm,
>   it is a source of major penalties that each time ./bootstrap
>   is run, it tries to download GNU Lib.  Now that it is a
>   submodule, it doesn't: once loaded, the Git repo of GNU Lib
>   is there, ready to be used.

I had been using ./bootstrap --gnulib-srcdir=/home/jdenny/gnulib to avoid 
this.  My approach also helped with your determinism point except that it 
didn't communicate with other developers.

> - ease of change
>   Now if we need to make changes to GNU Lib, we're using its
>   true Git repo.

.gitmodules references the read-only gnulib repo at the moment.  Is that 
what we want?

> For instance if you want to update gnulib, here's the sequence:

Thanks for that tutorial.  I updated to the latest gnulib, which I've 
tested and which has at least one change Bison uses.

>From 4af432ba25fdfc4555a423bad118bc4828947448 Mon Sep 17 00:00:00 2001
From: Joel E. Denny <address@hidden>
Date: Wed, 29 Oct 2008 10:22:01 -0400
Subject: [PATCH] * gnulib: Update submodule to HEAD.

---
 ChangeLog |    4 ++++
 gnulib    |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 759c0d4..95477a2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-10-29  Joel E. Denny  <address@hidden>
+
+       * gnulib: Update submodule to HEAD.
+
 2008-10-28  Joel E. Denny  <address@hidden>
 
        Update copyright year.
diff --git a/gnulib b/gnulib
index 7714a49..cdccece 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 7714a49bb734d63b6c73d0f533ee94a974f4024b
+Subproject commit cdccece5811c28f3ac95e1ae226967de25a8c387
-- 
1.5.4.3





reply via email to

[Prev in Thread] Current Thread [Next in Thread]