Re: [PATCH] Thank the developer of the initial push parser implementation.

[Odd Arild Olsen]

I just want an "I was here" tag as a kind of documentation for my CV. So my 
name in the THANKS file only is quite OK with me. 

With regards
O A Olsen


On Tirsdag 19 januar 2010, Joel E. Denny wrote:
> On Mon, 18 Jan 2010, Akim Demaille wrote:
> > If it is not the case (I don't have Bison at
> > hand), we should make sur Odd is credited in the NEWS file too.
> 
> No recent contributor is credited in the NEWS file, and there have been
> many.  I guess this is my fault as I had always thought the ChangeLog was
> the usual place for that.  It's fine with me to add Odd to NEWS, but we
> should add the rest of them at the same time.
> 
> However, I don't know how you want that to look.  Do we list all
> contributors for each feature?  In this case, Odd was the original
> developer.  Bob Rossi prepared it for modern Bison.  Paul Eggert, you, and
> I gave advice and made substantial code contributions before the first
> release.  Did I forget anyone?  We would have the same questions for
> recent features such as DOT, Java, named references, XML, etc.
> 
> If you want to get that started, I'll try to follow your lead.  However,
> do we postpone 2.4.2 until this is done?  I was hoping to roll it this
> week.
> 
> In any case, I just realized that Odd wasn't even properly credited in the
> ChangeLog when push.c was originally added to Bison, so I pushed this to
> master, branch-2.5, and branch-2.4.2.
> 
> From d6bdb90a2a2ced43828cf6591b3baf513d38285d Mon Sep 17 00:00:00 2001
> From: Joel E. Denny <address@hidden>
> Date: Tue, 19 Jan 2010 11:41:54 -0500
> Subject: [PATCH] ChangeLog (2006-09-15): add Odd Arild Olsen's role for
>  push.c.
> 
> ---
>  ChangeLog |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 5158576..d042287 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2010-01-19  Joel E. Denny  <address@hidden>
> +
> +     ChangeLog (2006-09-15): add Odd Arild Olsen's role for push.c.
> +
>  2010-01-15  Joel E. Denny  <address@hidden>
> 
>       Thank the developer of the initial push parser implementation.
> @@ -7989,9 +7993,12 @@
> 
>  2006-09-15  Bob Rossi  <address@hidden>
> 
> +     Add support for push parsing.  Based on the original work of
> +     Odd Arild Olsen <address@hidden>.
>       * data/Makefile.am (dist_pkgdata_DATA): Add push.c.
>       * data/c.m4 (YYPUSH): New.
>       (b4_push_if): New macro.  Use it instead of #ifdef YYPUSH.
> +     * data/push.c: New file.
>       * src/getargs.c (push_parser): New var.
>       * src/getargs.h (push_parser): New declaration.
>       * src/output.c (prepare): Add macro insertion of `push_flag'.
>