[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/2] symtab: fix some leaks
From: |
Theophile Ranquet |
Subject: |
[PATCH 1/2] symtab: fix some leaks |
Date: |
Wed, 12 Dec 2012 11:35:08 +0100 |
* src/symlist.c (symbol_list_free): Deep free it.
* src/symtab.c (symbols_free, semantic_types_sorted): Free it too.
(symbols_do, sorted): Call by address.
---
src/symlist.c | 2 ++
src/symtab.c | 23 ++++++++++++-----------
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/src/symlist.c b/src/symlist.c
index 196db4c..300eeda 100644
--- a/src/symlist.c
+++ b/src/symlist.c
@@ -119,6 +119,8 @@ symbol_list_free (symbol_list *list)
{
next = node->next;
named_ref_free (node->named_ref);
+ if (node->content_type == SYMLIST_TYPE)
+ free (node->content.sem_type);
free (node);
}
}
diff --git a/src/symtab.c b/src/symtab.c
index b8074a0..54155e1 100644
--- a/src/symtab.c
+++ b/src/symtab.c
@@ -801,6 +801,7 @@ symbols_free (void)
hash_free (semantic_type_table);
free (symbols);
free (symbols_sorted);
+ free (semantic_types_sorted);
}
@@ -823,19 +824,19 @@ symbols_cmp_qsort (void const *a, void const *b)
static void
symbols_do (Hash_processor processor, void *processor_data,
- struct hash_table *table, symbol **sorted)
+ struct hash_table *table, symbol ***sorted)
{
size_t count = hash_get_n_entries (table);
- if (!sorted)
+ if (!*sorted)
{
- sorted = xnmalloc (count, sizeof *sorted);
- hash_get_entries (table, (void**)sorted, count);
- qsort (sorted, count, sizeof *sorted, symbols_cmp_qsort);
+ *sorted = xnmalloc (count, sizeof **sorted);
+ hash_get_entries (table, (void**)*sorted, count);
+ qsort (*sorted, count, sizeof **sorted, symbols_cmp_qsort);
}
{
size_t i;
for (i = 0; i < count; ++i)
- processor (sorted[i], processor_data);
+ processor ((*sorted)[i], processor_data);
}
}
@@ -848,9 +849,9 @@ void
symbols_check_defined (void)
{
symbols_do (symbol_check_defined_processor, NULL,
- symbol_table, symbols_sorted);
+ symbol_table, &symbols_sorted);
symbols_do (semantic_type_check_defined_processor, NULL,
- semantic_type_table, semantic_types_sorted);
+ semantic_type_table, &semantic_types_sorted);
}
/*------------------------------------------------------------------.
@@ -905,7 +906,7 @@ symbols_token_translations_init (void)
for (i = 0; i < max_user_token_number + 1; i++)
token_translations[i] = undeftoken->number;
symbols_do (symbol_translation_processor, NULL,
- symbol_table, symbols_sorted);
+ symbol_table, &symbols_sorted);
}
@@ -918,10 +919,10 @@ void
symbols_pack (void)
{
symbols_do (symbol_check_alias_consistency_processor, NULL,
- symbol_table, symbols_sorted);
+ symbol_table, &symbols_sorted);
symbols = xcalloc (nsyms, sizeof *symbols);
- symbols_do (symbol_pack_processor, NULL, symbol_table, symbols_sorted);
+ symbols_do (symbol_pack_processor, NULL, symbol_table, &symbols_sorted);
/* Aliases leave empty slots in symbols, so remove them. */
{
--
1.8.0
- [PATCH 1/2] symtab: fix some leaks,
Theophile Ranquet <=