Re: [PATCH] scanner: reintroduce unput for missing end tokens

[Akim Demaille]

Le 12 déc. 2012 à 11:32, Theophile Ranquet <address@hidden> a écrit :

> * src/scan-gram.l (unexpected_end): Here.
> * tests/input.at: Adjust for new order of error reports.

Please, point to the commit which was reverted, and explain why what caused the 
original patch to be revert no longer holds today.  URLs would be useful too.

> index 5e5b1e8..70ad41b 100644
> --- a/tests/input.at
> +++ b/tests/input.at
> @@ -1480,10 +1480,10 @@ AT_CHECK([[$PERL -e "print 'start: \'';" >> empty.y 
> || exit 77]])
> 
> AT_BISON_CHECK([empty.y], [1], [],
> [[empty.y:2.8-9: warning: empty character literal [-Wother]
> -empty.y:3.8-4.0: warning: empty character literal [-Wother]
> empty.y:3.8-4.0: error: missing "'" at end of line
> -empty.y:4.8: warning: empty character literal [-Wother]
> +empty.y:3.8-4.0: warning: empty character literal [-Wother]
> empty.y:4.8: error: missing "'" at end of file
> +empty.y:4.8: warning: empty character literal [-Wother]
> ]])

I'd like to see -fcaret used here, to see how "cute" the location is.

> 
> AT_DATA([two.y],
> @@ -1495,10 +1495,10 @@ AT_CHECK([[$PERL -e "print 'start: \'ab';" >> two.y 
> || exit 77]])
> 
> AT_BISON_CHECK([two.y], [1], [],
> [[two.y:2.8-11: warning: extra characters in character literal [-Wother]
> -two.y:3.8-4.0: warning: extra characters in character literal [-Wother]
> two.y:3.8-4.0: error: missing "'" at end of line
> -two.y:4.8-10: warning: extra characters in character literal [-Wother]
> +two.y:3.8-4.0: warning: extra characters in character literal [-Wother]
> two.y:4.8-10: error: missing "'" at end of file
> +two.y:4.8-10: warning: extra characters in character literal [-Wother]
> ]])
> 
> AT_DATA([three.y],
> @@ -1510,10 +1510,10 @@ AT_CHECK([[$PERL -e "print 'start: \'abc';" >> 
> three.y || exit 77]])
> 
> AT_BISON_CHECK([three.y], [1], [],
> [[three.y:2.8-12: warning: extra characters in character literal [-Wother]
> -three.y:3.8-4.0: warning: extra characters in character literal [-Wother]
> three.y:3.8-4.0: error: missing "'" at end of line
> -three.y:4.8-11: warning: extra characters in character literal [-Wother]
> +three.y:3.8-4.0: warning: extra characters in character literal [-Wother]
> three.y:4.8-11: error: missing "'" at end of file
> +three.y:4.8-11: warning: extra characters in character literal [-Wother]
> ]])
> 
> AT_CLEANUP
> -- 
> 1.8.0
> 
>