[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] c++: better silencing of warnings
From: |
Akim Demaille |
Subject: |
Re: [PATCH 3/4] c++: better silencing of warnings |
Date: |
Mon, 21 Jan 2013 13:43:22 +0100 |
Le 21 janv. 2013 à 12:30, Théophile Ranquet <address@hidden> a écrit :
> 2013/1/21 Akim Demaille <address@hidden>:
>> You don't need to say it's valid C++ :)
>> The title is wrong btw, it's about tests, not about c++ generation.
>> And please clarify the kind of warnings fixed.
>
> Would this commit message satisfy you? BTW, we should also include a
> test for other faulty skeletons (lalr1.cc).
>
> commit 98945abaed5ff838e4a3d44d8a0a99b7ed5dc1cb
> Author: Theophile Ranquet <address@hidden>
> Date: Tue Jan 15 18:03:39 2013 +0100
>
> tests: better silencing of unused parameter warnings
Good with me, expect that I prefer keeping "parameter" for
templates, and "argument" for functions (I'm referring to
the title, obviously not the error message :).
>
> input.yy:35:44: error: unused parameter 'msg' [-Werror,-Wunused-parameter]
> void yy::parser::error (std::string const& msg)
> ^
>
> * tests/c++.at (C++ GLR parser identifier shadowing): Don't name unused
> argument, use YYUSE instead of a direct cast to void.
[PATCH 2/4] bench: compatibility for Bison <= 2.7, Theophile Ranquet, 2013/01/21