[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bongo-devel] Re: VLC and audio CD's
From: |
Daniel Jensen |
Subject: |
[bongo-devel] Re: VLC and audio CD's |
Date: |
Wed, 04 Apr 2007 17:14:24 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) |
Daniel Brockman <address@hidden> writes:
> I added case to all the descriptions (e.g., `URI'),
> and used `completion-ignore-case' for convenience.
Good. I didn't read that far in the documentation.
>> "An alist of insertion commands for `bongo-insertion-dispatcher'.")
>
> You should usually elide articles from the start of docstrings.
It is very common in Emacs sources (hundreds of cases). Is this
mentioned in a style guide somewhere?
>> (let ((command (cdr (assoc (completing-read "Insert: "
>> bongo-insertion-commands nil t)
>> bongo-insertion-commands))))
>> (and command (call-interactively command))))
>
> I removed the `(and command ...)' check, because I figured
> it should never fail so it's clearer to just let it blow up.
> (Let me know if you think this is a mistake.)
It will fail if the user enters an empty string. We shouldn't use a
default value in that case (hence the check), though a message might
be OK.
- [bongo-devel] VLC and audio CD's, Joel Molin, 2007/04/03
- Re: [bongo-devel] VLC and audio CD's, Daniel Brockman, 2007/04/03
- [bongo-devel] Re: VLC and audio CD's, Joel Molin, 2007/04/03
- [bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/04
- Re: [bongo-devel] Re: VLC and audio CD's, Daniel Brockman, 2007/04/04
- [bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/05
- Re: [bongo-devel] Re: VLC and audio CD's, Daniel Brockman, 2007/04/05
- [bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/05
- Re: [bongo-devel] Re: VLC and audio CD's, Daniel Brockman, 2007/04/05
[bongo-devel] Re: VLC and audio CD's, Daniel Jensen, 2007/04/03