Re: [Bug-apl] svn 863 make warning/error

[Bill Heagy]

The problem seems to be about assert level rather than parallel, even 
before SVN 867.

SVN 867
make clean
./configure ASSERT_LEVEL_WANTED=0
./configure
.
.
.
++ -DHAVE_CONFIG_H -I. -I..    -Werror -Wall -I sql -I/usr/include 
-rdynamic -g -O2 -MT apl-PrimitiveFunction.o -MD -MP -MF 
.deps/apl-PrimitiveFunction.Tpo -c -o apl-PrimitiveFunction.o `test -f 
'PrimitiveFunction.cc' || echo './'`PrimitiveFunction.cc
In file included from Common.hh:52:0,
                 from PrimitiveFunction.hh:24,
                 from PrimitiveOperator.hh:24,
                 from Bif_OPER2_RANK.hh:24,
                 from Prefix.cc:21:
Prefix.cc: In member function ‘bool Prefix::replace_AB(Value_P, Value_P)’:
Prefix.cc:711:11: error: could not convert ‘old_value’ from ‘Value_P’ to 
‘bool’
    Assert(old_value);

Assert.hh:40:27: note: in definition of macro ‘Assert’
 #define Assert(x)    if ((x)) {}
                           ^
Prefix.cc:712:11: error: could not convert ‘new_value’ from ‘Value_P’ to 
‘bool’
    Assert(new_value);

Assert.hh:40:27: note: in definition of macro ‘Assert’
 #define Assert(x)    if ((x)) {}
                           ^
Makefile:2469: recipe for target 'apl-Prefix.o' failed
make[3]: *** [apl-Prefix.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from Common.hh:52:0,
                 from Backtrace.hh:26,
                 from Error.hh:24,
                 from PointerCell.cc:21:
PointerCell.cc: In member function ‘virtual PrintBuffer 
PointerCell::character_representation(const PrintContext&) const’:
PointerCell.cc:156:11: error: could not convert ‘val’ from ‘Value_P’ to 
‘bool’
    Assert(val);

Assert.hh:40:27: note: in definition of macro ‘Assert’
 #define Assert(x)    if ((x)) {}
                           ^
Makefile:2483: recipe for target 'apl-PointerCell.o' failed
make[3]: *** [apl-PointerCell.o] Error 1
mv -f .deps/apl-Parser.Tpo .deps/apl-Parser.Po
mv -f .deps/apl-PrimitiveFunction.Tpo .deps/apl-PrimitiveFunction.Po
make[3]: Leaving directory '/home/wheagy/apl_svn/trunk/src'
Makefile:3161: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/home/wheagy/apl_svn/trunk/src'
Makefile:521: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/wheagy/apl_svn/trunk'
Makefile:409: recipe for target 'all' failed
make: *** [all] Error 2

On 28/01/17 03:47 PM, Juergen Sauermann wrote:
> Hi Bill,
>
> thanks, hopefully fixed in *SVN 867*.
>
> Please keep in mind that 'make parallel ' is experimental and contains
> bugs in ScalarFunction.cc that I was not able to reproduce because they
> only occur sporadically.
>
> /// Jürgen
>
>
> On 01/28/2017 08:15 PM, Bill Heagy wrote:
> > debian, 32-bit or 64-bit, testing
> >
> > SVN 865 and previous versions
> >
> > If I do:
> >
> > make clean
> >
> > ./configure  CORE_COUNT_WANTED=syl
> >
> > make
> >
> > everything is fine.
> >
> > If I do:
> >
> > make clean
> >
> > ./configure
> >
> > make parallel
> >
> > I get:
> >
> > .
> >
> > .
> >
> > .
> >
> > g++ -DHAVE_CONFIG_H -I. -I..    -Werror -Wall -I sql -I/usr/include
> > -rdynamic -g -O2 -MT apl-Avec.o -MD -MP -MF .deps/apl-Avec.Tpo -c -o
> > apl-Avec.o `test -f 'Avec.cc' || echo './'`Avec.cc
> > Archive.cc: In member function ‘void XML_Loading_Archive::read_Ravel()’:
> > Archive.cc:1598:20: error: unused variable ‘next’ [-Werror=unused-variable]
> >       const Unicode next = UTF8_string::toUni(cells, len, true);
> >                     ^~~~
> > .
> >
> > .
> >
> > .
> >
> > g++ -DHAVE_CONFIG_H -I. -I..    -Werror -Wall -I sql -I/usr/include
> > -rdynamic -g -O2 -MT apl-Bif_OPER1_COMMUTE.o -MD -MP -MF
> > .deps/apl-Bif_OPER1_COMMUTE.Tpo -c -o apl-Bif_OPER1_COMMUTE.o `test -f
> > 'Bif_OPER1_COMMUTE.cc' || echo './'`Bif_OPER1_COMMUTE.cc
> > Bif_F12_FORMAT.cc: In member function ‘void
> > Bif_F12_FORMAT::Format_LIFER::fill_data_fields(double, UCS_string&,
> > UCS_string&, UCS_string&, bool&)’:
> > Bif_F12_FORMAT.cc:678:19: error: unused variable ‘flen’ 
> [-Werror=unused-variable]
> >          const int flen = snprintf(format, sizeof(format), "%%.%luE",
> >                    ^~~~
> > Bif_F12_FORMAT.cc:682:19: error: unused variable ‘dlen’ 
> [-Werror=unused-variable]
> >          const int dlen = snprintf(&data_buf[0], data_buf_len, format, value);
> >                    ^~~~
> > Bif_F12_FORMAT.cc:701:19: error: unused variable ‘flen’ 
> [-Werror=unused-variable]
> >          const int flen = snprintf(format, sizeof(format), "%%.%luf",
> >                    ^~~~
> > .
> >
> > .
> >
> > .
> >
> > cc1plus: all warnings being treated as errors
> > Makefile:1811: recipe for target 'apl-Archive.o' failed
> > make[4]: *** [apl-Archive.o] Error 1
> > make[4]: *** Waiting for unfinished jobs....
> > cc1plus: all warnings being treated as errors
> > Makefile:1881: recipe for target 'apl-Bif_F12_FORMAT.o' failed
> > make[4]: *** [apl-Bif_F12_FORMAT.o] Error 1
> > mv -f .deps/apl-Bif_OPER1_EACH.Tpo .deps/apl-Bif_OPER1_EACH.Po
> > mv -f .deps/apl-Bif_OPER2_POWER.Tpo .deps/apl-Bif_OPER2_POWER.Po
> > make[4]: Leaving directory '/home/wheagy/apl_svn/trunk/src'
> > Makefile:3161: recipe for target 'all-recursive' failed
> > make[3]: *** [all-recursive] Error 1
> > make[3]: Leaving directory '/home/wheagy/apl_svn/trunk/src'
> > Makefile:521: recipe for target 'all-recursive' failed
> > make[2]: *** [all-recursive] Error 1
> > make[2]: Leaving directory '/home/wheagy/apl_svn/trunk'
> > Makefile:409: recipe for target 'all' failed
> > make[1]: *** [all] Error 2
> > make[1]: Leaving directory '/home/wheagy/apl_svn/trunk'
> > Makefile:997: recipe for target 'parallel' failed
> > make: *** [parallel] Error 2
> >
> > On 28/01/17 12:35 PM, Juergen Sauermann wrote:
> >> Hi,
> >>
> >> the problem is in *ScalarFunction.cc*. The compiler complains about a pointer
> >> which is not
> >> initialized in the constructor (which is on purpose, but the compiler seems 
> not
> >> to like it).
> >>
> >> The pointer is initialized at a later point in time (at 
> *ScalarFunction.cc:255*)
> >> but the compiler
> >> seems not to accept that.
> >>
> >> Please try *SVN 865**.*
> >>
> >> /// Jürgen
> >>
> >>
> >> On 01/28/2017 05:16 PM, address@hidden wrote:
> >> > Hi Jürgen
> >> >
> >> > Sorry, still getting the same 'warning->error' in 864
> >> >
> >> > is the problem in Simple_string.hh or ScalarFunction.cc ?? (i see your code
> >> changes in ScalarFunction.cc)
> >> >
> >> > thanks
> >> >
> >> >
> >> >
> >> > g++ -DHAVE_CONFIG_H -I. -I..    -Werror -Wall -I sql -I/usr/local/include
> >> -rdynamic -g -O2 -MT apl-Symbol.o -MD -MP -MF .deps/apl-Symbol.Tpo -c -o
> >> apl-Symbol.o `test -f 'Symbol.cc' || echo './'`Symbol.cc
> >> > cc1plus: warnings being treated as errors
> >> > Simple_string.hh: In static member function 'static void
> >> ScalarFunction::PF_eval_scalar_B(Thread_context&)':
> >> > Simple_string.hh:133: error: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__delta' may be used uninitialized in this function
> >> > ScalarFunction.cc:339: note: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__delta' was declared here
> >> > Simple_string.hh:133: error: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__pfn' may be used uninitialized in this function
> >> > ScalarFunction.cc:339: note: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__pfn' was declared here
> >> > Simple_string.hh:133: error: 'j1.PJob_scalar_B::fun' may be used
> >> uninitialized in this function
> >> > ScalarFunction.cc:339: note: 'j1.PJob_scalar_B::fun' was declared here
> >> > make[3]: *** [apl-ScalarFunction.o] Error 1
> >> > make[3]: *** Waiting for unfinished jobs....
> >> > mv -f .deps/apl-StateIndicator.Tpo .deps/apl-StateIndicator.Po
> >> > mv -f .deps/apl-Svar_DB.Tpo .deps/apl-Svar_DB.Po
> >> > mv -f .deps/apl-Symbol.Tpo .deps/apl-Symbol.Po
> >> > make[3]: Leaving directory `/transfer/usr.src/apl/apl-864/src'
> >> > make[2]: *** [all-recursive] Error 1
> >> > make[2]: Leaving directory `/transfer/usr.src/apl/apl-864/src'
> >> > make[1]: *** [all-recursive] Error 1
> >> > make[1]: Leaving directory `/transfer/usr.src/apl/apl-864'
> >> > make: *** [all] Error 2
> >> >
> >> >
> >> >
> >> >
> >> >
> >> > On Sat, 28 Jan 2017 15:01:26 +0100
> >> > Juergen Sauermann<address@hidden> wrote:
> >> >
> >> >> Hi,
> >> >>
> >> >> thanks, hopefully fixed in SVN 864.
> >> >>
> >> >> /// Jürgen
> >> >>
> >> >>
> >> >> On 01/27/2017 11:51 PM,address@hidden  wrote:
> >> >>
> >> >>
> >> >> i removed the -Werror   in the src/Makefile   line 680    common_CXXFLAGS
> >> = -Werror -Wall -I sql $(am__append_2) $(am__append_6)   and make gave good
> >> apl *so far in my testing)
> >> >>
> >> >>
> >> >> On Fri, 27 Jan 2017 15:16:14 -0700
> >> >> address@hidden  wrote:
> >> >>
> >> >>
> >> >> on this computer   I thought svn 863 compiled but it left 1.6 installed so
> >> didn't notice
> >> >>
> >> >> libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -Werror -Wall -I sql
> >> -I/usr/local/include -rdynamic -g -O2 -MT libapl_la-ValueHistory.lo -MD -MP
> >> -MF .deps/libapl_la-ValueHistory.Tpo -c ValueHistory.cc -o
> >> libapl_la-ValueHistory.o >/dev/null 2>&1
> >> >> cc1plus: warnings being treated as errors
> >> >> Simple_string.hh: In static member function 'static void
> >> ScalarFunction::PF_eval_scalar_B(Thread_context&)':
> >> >> Simple_string.hh:133: error: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__delta' may be used uninitialized in this function
> >> >> ScalarFunction.cc:335: note: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__delta' was declared here
> >> >> Simple_string.hh:133: error: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__pfn' may be used uninitialized in this function
> >> >> ScalarFunction.cc:335: note: 'j1.PJob_scalar_B::fun1.ErrorCode
> >> (Cell::*)(Cell*)const::__pfn' was declared here
> >> >> Simple_string.hh:133: error: 'j1.PJob_scalar_B::fun' may be used
> >> uninitialized in this function
> >> >> ScalarFunction.cc:335: note: 'j1.PJob_scalar_B::fun' was declared here
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >
> >>
> >
> >

--
Bill Heagy
615 Country Club Drive                        mailto:address@hidden
London, Ontario N6C 5P8 Canada                telephone: 519-680-0311