Re: more variable quoting needed

[Paul Eggert]

> From: Stephen Gildea <address@hidden>
> Date: Wed, 08 May 2002 11:58:07 -0400
>
> Looking at the configure script more, I see that many variable
> references are missing the necessary double quotes.

In general, variables are not quoted if they are supposed to always
contain values like "yes" or "no" that never need quoting.  Admittedly
the ice is thin here; e.g. if you do something strange like set
ac_cv_sys_tiocgwinsz_in_termios_h="" in your environment, the
configure script will stop working.  However, I think that fixing this
will require stronger medicine than merely quoting the vars (which
merely masks the problem).  It really requires sanity-checking each
var, which will be a bit of a pain to implement.

Anyway, with the above convention in mind, the bug here is that the
variable is not set; it should be set.  I have installed the following
patch to fix this.  Thanks for reporting it.

2002-05-08  Paul Eggert  <address@hidden>

        * lib/autoconf/headers.m4 (AC_HEADER_TIOCGWINSZ):
        Don't require AC_SYS_POSIX_TERMIOS.  The test is unnecessary,
        and it causes a 'test' syntax error if it fails.
        Bug reported by Stephen Gildea.

--- headers.m4.~1.19.~  2002-03-02 07:19:48.000000000 -0800
+++ headers.m4  2002-05-08 13:20:27.292281000 -0700
@@ -536,10 +536,7 @@ m4_define([_AC_HEADER_TIOCGWINSZ_IN_SYS_
 # FIXME: Is this the proper name?  Is this the proper implementation?
 # I need more help.
 AC_DEFUN([AC_HEADER_TIOCGWINSZ],
-[AC_REQUIRE([AC_SYS_POSIX_TERMIOS])dnl
-if test $ac_cv_sys_posix_termios = yes; then
-  _AC_HEADER_TIOCGWINSZ_IN_TERMIOS_H
-fi
+[_AC_HEADER_TIOCGWINSZ_IN_TERMIOS_H
 if test $ac_cv_sys_tiocgwinsz_in_termios_h != yes; then
   _AC_HEADER_TIOCGWINSZ_IN_SYS_IOCTL
   if test $ac_cv_sys_tiocgwinsz_in_sys_ioctl_h = yes; then