[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Reduce startup cost of autotest.
From: |
Eric Blake |
Subject: |
[PATCH] Reduce startup cost of autotest. |
Date: |
Fri, 2 Jul 2010 14:07:51 -0600 |
* lib/autotest/general.m4 (_AT_FINISH) <banners>: Rather than
doing a recursive find, limit ourselves to top ChangeLog only.
Reported by Ralf Wildenhues.
Signed-off-by: Eric Blake <address@hidden>
---
> I still find the ChangeLog snippet useful, but seldom see packages with
> one ChangeLog per directory
In fact, of the packages that I regularly test that use autotest
(m4, libtool, bison, tar, and autoconf itself), they all have the
common property of a single ChangeLog belonging to the package;
and while m4 also has gnulib/ChangeLog, that can be reconstructed
by the fact that gnulib is a git submodule, and updating the
submodule is an action documented in the top ChangeLog.
ChangeLog | 7 +++++++
lib/autotest/general.m4 | 22 ++++++----------------
2 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 82df57c..4c31e0e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-07-02 Eric Blake <address@hidden>
+
+ Reduce startup cost of autotest.
+ * lib/autotest/general.m4 (_AT_FINISH) <banners>: Rather than
+ doing a recursive find, limit ourselves to top ChangeLog only.
+ Reported by Ralf Wildenhues.
+
2010-07-02 Ralf Wildenhues <address@hidden>
New macro AC_FC_FIXEDFORM, improved AC_FC_FREEFORM, coverage.
diff --git a/lib/autotest/general.m4 b/lib/autotest/general.m4
index 57b3fef..2b46705 100644
--- a/lib/autotest/general.m4
+++ b/lib/autotest/general.m4
@@ -978,23 +978,13 @@ AS_BOX(m4_defn([AT_TESTSUITE_NAME])[.])
AS_ECHO([" \$ $[0] $at_cli_args"])
echo
- # Try to find a few ChangeLogs in case it might help determining the
- # exact version. Use the relative dir: if the top dir is a symlink,
- # find will not follow it (and options to follow the links are not
- # portable), which would result in no output here. Prune directories
- # matching the package tarname, since they tend to be leftovers from
- # `make dist' or `make distcheck' and contain redundant or stale logs.
- if test -n "$at_top_srcdir"; then
- AS_BOX([ChangeLogs.])
+ # If ChangeLog exists, list a few lines in case it might help determining
+ # the exact version.
+ if test -n "$at_top_srcdir" && test -f "$at_top_srcdir/ChangeLog"; then
+ AS_BOX([ChangeLog.])
+ echo
+ sed 's/^/| /;10q' "$at_top_srcdir/ChangeLog"
echo
- for at_file in `find "$at_top_srcdir" m4_ifdef([AT_PACKAGE_TARNAME],
-[-name "AT_PACKAGE_TARNAME-*" -prune -o ])-name ChangeLog -print`
- do
- AS_ECHO(["$as_me: $at_file:"])
- sed 's/^/| /;10q' $at_file
- echo
- done
-
fi
AS_UNAME
--
1.7.1