[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: testsuite failure - 193 parallel execution
From: |
Eric Blake |
Subject: |
Re: testsuite failure - 193 parallel execution |
Date: |
Tue, 20 Jul 2010 15:55:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5 |
On 07/20/2010 03:52 PM, Paul Eggert wrote:
> On 07/20/10 14:47, Eric Blake wrote a bunch of good questions,
> ending with:
>
>> And how does signal handling fit in with interrupting a child test?
>
> OK, you're right, a plain pipe is not going to work. How about
> this much-smaller fix instead? It builds on your idea to make
> sure that the 'read at_token' commands succeed.
>
> @@ -1410,7 +1410,9 @@ dnl kill -13 $$
> fi
> shift # Consume one token.
> if test address@hidden:@] -gt 0; then :; else
> - read at_token <&AT_JOB_FIFO_FD || break
> + # The 'until' loop avoids a race condition if we happen to open
> + # the fifo between the time a child outputs a token and it exits.
> + until read at_token; do :; done <&AT_JOB_FIFO_FD
Hmm - IIUC, the '|| break' that you are deleting is there in case
something kills off the child and it never gets around to writing a
token, at which point we've now put the parent into an inf-loop waiting
for a token that will never arrive. Are we sure we want to do this?
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: testsuite failure - 193 parallel execution, (continued)
- Re: testsuite failure - 193 parallel execution, Paul Eggert, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Eric Blake, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Eric Blake, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Eric Blake, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Paul Eggert, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Paul Eggert, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Eric Blake, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Paul Eggert, 2010/07/20
- Re: testsuite failure - 193 parallel execution,
Eric Blake <=
- Re: testsuite failure - 193 parallel execution, Paul Eggert, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Eric Blake, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Ralf Wildenhues, 2010/07/20
- Re: testsuite failure - 193 parallel execution, Eric Blake, 2010/07/20
- [PATCH] Avoid passing autotest job fds to test groups., Ralf Wildenhues, 2010/07/21
- Re: [PATCH] Avoid passing autotest job fds to test groups., Eric Blake, 2010/07/21
- Re: [PATCH] Avoid passing autotest job fds to test groups., Ralf Wildenhues, 2010/07/21
- Re: [PATCH] Avoid passing autotest job fds to test groups., Eric Blake, 2010/07/21
- Re: [PATCH] Avoid passing autotest job fds to test groups., Ralf Wildenhues, 2010/07/21
- [PATCH] Plug race in parallel autotest., Eric Blake, 2010/07/20