bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

suggested fix for "make installcheck"


From: Steve M. Robbins
Subject: suggested fix for "make installcheck"
Date: Sat, 7 Jul 2001 14:37:42 -0400
User-agent: Mutt/1.3.18i

Hi,

There is a (recently added?) check for files remaining after "make
install / make uninstall".  Unfortunately, there is no error message
given if this check fails.  Enclosed is a patch to rectify this.

Regards,
-Steve

2001-07-07  Steve M. Robbins  <address@hidden>

        * lib/am/distdir.am (distcheck): Emit diagnostic when files
        remain after "make uninstall".

Index: lib/am/distdir.am
===================================================================
RCS file: /cvs/automake/automake/lib/am/distdir.am,v
retrieving revision 1.19
diff -u -b -B -r1.19 distdir.am
--- distdir.am  2001/05/15 02:21:53     1.19
+++ distdir.am  2001/07/07 18:35:07
@@ -262,7 +262,9 @@
          && $(MAKE) $(AM_MAKEFLAGS) installcheck \
          && $(MAKE) $(AM_MAKEFLAGS) uninstall \
 ## We use -le 1 because the `dir' file might still exist after uninstall.
-         && test `find $$dc_install_base -type f -print | wc -l` -le 1 \
+         && (test `find $$dc_install_base -type f -print | wc -l` -le 1 \
+            || (echo "Error: files left after uninstall" 1>&2; \
+                exit 1) ) \
          && $(MAKE) $(AM_MAKEFLAGS) dist \
          && $(MAKE) $(AM_MAKEFLAGS) distclean \
 ## Make sure to remove the dist file we created in the test build


-- 
by Rocket to the Moon,
by Airplane to the Rocket,
by Taxi to the Airport,
by Frontdoor to the Taxi,
by throwing back the blanket and laying down the legs ...
- They Might Be Giants




reply via email to

[Prev in Thread] Current Thread [Next in Thread]