automake 1.5 mishandles `make bin='$(prefix)/foo''

[Paul Eggert]

With the GNU tar 1.13.25 distribution, when I run a comand like

   make bin='$(prefix)/foo'

on a GNU/Linux box (Debian potato), the build fails, because the
generated Makefile contains a line like this:

        @set fnord $(MAKEFLAGS); amf=$$2; \

In this case, this expands to

        @set fnord ... bin=$(prefix)/foo... ; amf=$$2; \

and the shell then attempts to run the shell command 'prefix'.

Here is a patch.

2001-10-01  Paul Eggert  <address@hidden>

        * lib/am/subdirs.am:
        ($(RECURSIVE_TARGETS), maintainer-clean-recursive):
        $(MAKEFLAGS) -> $$MAKEFLAGS, so that we don't run into problems if
        MAKEFLAGS contains '$(...)'.

===================================================================
RCS file: lib/am/subdirs.am,v
retrieving revision 1.5
retrieving revision 1.5.0.1
diff -pu -r1.5 -r1.5.0.1
--- lib/am/subdirs.am   2001/04/09 14:44:04     1.5
+++ lib/am/subdirs.am   2001/10/01 21:05:28     1.5.0.1
@@ -32,7 +32,7 @@ check-recursive installcheck-recursive
 # (2) otherwise, pass the desired values on the `make' command line.
 
 $(RECURSIVE_TARGETS):
-       @set fnord $(MAKEFLAGS); amf=$$2; \
+       @set fnord $$MAKEFLAGS; amf=$$2; \
        dot_seen=no; \
        target=`echo $@ | sed s/-recursive//`; \
        list='$(SUBDIRS)'; for subdir in $$list; do \
@@ -69,7 +69,7 @@ maintainer-clean-recursive
 ## bombs.
 mostlyclean-recursive clean-recursive distclean-recursive \
 maintainer-clean-recursive:
-       @set fnord $(MAKEFLAGS); amf=$$2; \
+       @set fnord $$MAKEFLAGS; amf=$$2; \
        dot_seen=no; \
 ## For distclean and maintainer-clean we make sure to use the full
 ## list of subdirectories.  We do this so that `configure; make