bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: use 'jot' if available


From: Ralf Wildenhues
Subject: Re: use 'jot' if available
Date: Tue, 19 May 2009 07:51:42 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

* Peter O'Gorman wrote on Tue, May 19, 2009 at 12:03:34AM CEST:
> Ralf Wildenhues wrote:
> > * Peter O'Gorman wrote on Mon, May 18, 2009 at 03:43:00AM CEST:
> >> Also, I wonder if it is worth checking for bsd''s 'jot' utility in these
> >> tests that use seq?
> > 
> > That sounds like a good idea to me.  I didn't know jot.
> > I'm pushing this.

> I just had a quick look at a few systems, and unfortunately, on IRIX,
> /usr/sbin/jot exists and is a graphical text editor. It also does not
> exit with a non-zero exit code on failure, so e.g. DISPLAY=no_display;
> export DISPLAY in the tests won't help to catch it.

Bummer.  Oh well, let's just revert this.  Thanks for checking!

Cheers,
Ralf

    Revert last patch, IRIX has an editor named `jot'.
    
    * tests/instmany-mans.test: Do not try `jot'.
    * tests/instmany-python.test: Likewise.
    * tests/instmany.test: Likewise.
    Report by Peter O'Gorman.

diff --git a/tests/instmany-mans.test b/tests/instmany-mans.test
index 5fafa67..fcee60b 100755
--- a/tests/instmany-mans.test
+++ b/tests/instmany-mans.test
@@ -31,8 +31,8 @@ limit=2500
 subdir=long_subdir_name_with_many_characters
 nfiles=81
 
-# Let's use `seq' or `jot' if available, they are faster than the loop.
-list=`(seq 1 $nfiles) 2>/dev/null || (jot $nfiles) 2>/dev/null || {
+# Let's use `seq' if available, it's faster than the loop.
+list=`(seq 1 $nfiles) 2>/dev/null || {
   i=1
   while test $i -le $nfiles; do
     echo $i
diff --git a/tests/instmany-python.test b/tests/instmany-python.test
index 9407948..6831c9e 100755
--- a/tests/instmany-python.test
+++ b/tests/instmany-python.test
@@ -27,7 +27,7 @@ limit=2500
 subdir=long_subdir_name_with_many_characters
 nfiles=81
 
-list=`(seq 1 $nfiles) 2>/dev/null || (jot $nfiles) 2>/dev/null || {
+list=`(seq 1 $nfiles) 2>/dev/null || {
   i=1
   while test $i -le $nfiles; do
     echo $i
diff --git a/tests/instmany.test b/tests/instmany.test
index e423710..a3b10cb 100755
--- a/tests/instmany.test
+++ b/tests/instmany.test
@@ -39,8 +39,8 @@ limit=2500
 subdir=long_subdir_name_with_many_characters
 nfiles=81
 
-# Let's use `seq' or `jot' if available, they are faster than the loop.
-list=`(seq 1 $nfiles) 2>/dev/null || (jot $nfiles) 2>/dev/null || {
+# Let's use `seq' if available, it's faster than the loop.
+list=`(seq 1 $nfiles) 2>/dev/null || {
   i=1
   while test $i -le $nfiles; do
     echo $i




reply via email to

[Prev in Thread] Current Thread [Next in Thread]