bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#7849: new instspc* test failures


From: Stefano Lattarini
Subject: bug#7849: new instspc* test failures
Date: Thu, 05 Jan 2012 09:38:38 +0100

Hi Peter, thanks for the patch.  Looks good, modulo a couple of nits
below.  Feel free to push to master when they have been addressed.

On 01/05/2012 01:35 AM, Peter Rosin wrote:
>
> From 27100f0b94f8e38e8bd30c27277d7ad4e9f4dd1a Mon Sep 17 00:00:00 2001
> From: Peter Rosin <address@hidden>
> Date: Thu, 5 Jan 2012 01:29:27 +0100
> Subject: [PATCH] tests: work around strangeness in MSYS
> 
> MSYS mishandles carriage returns and behaves very strange for
>
s/strange/strangely/?  Not a rhetorical question -- "strangely" seems
more correct to me, but I'm not sure it really is.

> directories with colon in them. It seems that colon-directories are
> somehow mixed up with drive letters.
> 
> Fixes automake bug#7849.
> 
> * tests/instspc.tap: Skip instead of erroring out when $test_string
> is empty for the carriageret case, as that is expected on MSYS. Also,
> for similar reasons, skip instead of erroring out when it is not
> possible to cd into the just created directory, and the directory
> name contains a colon.
>
I assume that, after your changes, this test doesn't error out anymore
and doesn't experience any failure even on MSYS.  Right?  If there are
still failures, it might be worth stating it in the commit message.

> ---
>  tests/instspc.tap |   28 +++++++++++++++++++++++++++-
>  1 files changed, 27 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/instspc.tap b/tests/instspc.tap
> index 9eb145f..2e9641c 100755
> --- a/tests/instspc.tap
> +++ b/tests/instspc.tap
>
The copyright years should be updated (the `update-copyright' script
from gnulib can help you with this chore).

> [SNIP]

Thanks,
  Stefano





reply via email to

[Prev in Thread] Current Thread [Next in Thread]