bug#11222: Vala projects with vapi in *_SOURCES are broken with automake 1.11.4

[Stefano Lattarini]

On 04/11/2012 11:20 AM, Marc-Antoine Perennou wrote:
> Hello,
>
Hello Marc-Antoine, thanks for the report.

> bug#10894 introduced a regression in commit
> 51f61dfb1e861062aaa1d73fab71278c85fe0594
> <http://git.savannah.gnu.org/cgit/automake.git/commit/?id=51f61dfb1e861062aaa1d73fab71278c85fe0594>
>
> Formerly it was using the whole content of the *_SOURCES variable, which
> was causing problems with mixed C/vala projects, so you only grepped *.vala
> files from it.
> Fact is that not all vala files ends with the .vala extension, some of them
> end with the .vapi extension, and they are currently ignored.
>
Ouch :-(  This shows once again that our current testsuite coverage for the
Vala support is inadequate (and that my knowledge of Vala is pitiful, but
that was already waaay too clear I guess).

> Attached patch fixes this issue
> 
> I can also write & provide a test
> 
That would be great, thank you!  But if you do so, could you please try
to keep your test as short as possible (< 15 lines), to avoid issues with
copyright assignments?

I know this sounds like an absurd request, but the fact is: I'd like to
apply your fix and add your new test ASAP (for an "emergency" 1.11.5
release), and that would basically become impossible if we were to wait
for a copyright assignment form to fly over the Atlantic :-(  But if
your change is small and simple enough, the FSF allows it to be applied
without a copyright disclaimer, so we could have the new release in
a couple of days.

Thanks again for your help,
  Stefano