[Bug gas/628] gas emits duplicate line-number info for each instruction

[wilson at specifixinc dot com]

------- Additional Comments From wilson at specifixinc dot com  2005-01-04 
05:50 -------
Created an attachment (id=335)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=335&action=view)
Fix for duplicate line number info emitted by gas.

Here is the finished patch that I checked in.

I moved the loc_directive_seen bitfield into struct slot, and fixed the users. 
I added a comment before dot_loc as required by the coding conventions, and
deleted the now misleading and unnecessary comment inside the function.  I
moved addr inside the new if statement, and deleted the now unnecessary braces
around the if statement.  These are all pretty minor changes.

This was tested by hand by comparing .S output, readelf -wl output, and objdump
-d output, to verify that all of the addresses and line numbers in the readelf
output were correct.

This was tested by a binutils, gcc, and gdb build, followed by a gdb make
check.  The gcc build was C and C++ only, non-bootstapped.  I get 16 additional
passes with the patch, about half in gdb.base, and half in gdb.mi.  There is
one testcase in gdb.threads that seems to alternate between pass and kfail
which I ignored.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=628

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.