|
From: | Nick Clifton |
Subject: | Re: [PATCH] don't crash on overflow on hppa64 |
Date: | Thu, 28 Jul 2011 14:26:58 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 |
Hi Mikulas,
1. offset is 64-bit, but 32-bit format "%lx" is used. This causes parameters mismatch 2. eh may be NULL. If it is NULL, I changed the code to print "unknown". Someone who understands the code better can change it to print something more descriptive 3. returning bfd_reloc_notsupported causes abort() in elf64_hppa_relocate_section. Change it to return bfd_reloc_overflow.
I have applied your patch, along with Joseph's suggestion of using BFD_VMA_FMT. I used the following changelog entry.
Cheers Nick bfd/ChangeLog 2011-07-28 Mikulas Patocka <address@hidden> * elf64-hppa.c (elf_hppa_final_link_relocate): Fix handling of out of range branches.
[Prev in Thread] | Current Thread | [Next in Thread] |