[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug gas/18561] sh assembler wrongly constant-folds address expressions
From: |
bugdal at aerifal dot cx |
Subject: |
[Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols |
Date: |
Fri, 21 Aug 2015 09:41:17 +0000 |
https://sourceware.org/bugzilla/show_bug.cgi?id=18561
--- Comment #4 from Rich Felker <bugdal at aerifal dot cx> ---
Indeed, that fixes it. However I'm skeptical of the way you're making the
change:
1. S_FORCE_RELOC already has logic to force relocations for weak symbols when
the strict argument is nonzero, so I wonder if something is wrongly calling it
with strict=0 instead of strict=1?
2. Resolving the value of a weak symbol at as-time is always wrong, regardless
of target or 'strictness' (whatever that's intended to mean). If the bug were
in an sh-specific file, I would be satisfied with an sh-specific fix, but since
it seems to be in symbol.c, this may indicate a bug that's affecting other
targets too, and that should be fixed globally rather than via a
target-specific optional macro.
Thoughts?
--
You are receiving this mail because:
You are on the CC list for the bug.
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, nickc at redhat dot com, 2015/08/17
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, bugdal at aerifal dot cx, 2015/08/17
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, nickc at redhat dot com, 2015/08/21
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols,
bugdal at aerifal dot cx <=
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, nickc at redhat dot com, 2015/08/21
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, nickc at redhat dot com, 2015/08/21
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, bugdal at aerifal dot cx, 2015/08/21
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, amodra at gmail dot com, 2015/08/21
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, bugdal at aerifal dot cx, 2015/08/21
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, glaubitz at physik dot fu-berlin.de, 2015/08/22
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, bugdal at aerifal dot cx, 2015/08/22
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, nickc at redhat dot com, 2015/08/24
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, bugdal at aerifal dot cx, 2015/08/24
- [Bug gas/18561] sh assembler wrongly constant-folds address expressions containing weak symbols, nickc at redhat dot com, 2015/08/24