[Bug binutils/22823] bfd/libbfd.h:268:4: error: cast between incompatible function types from ‘bfd_boolean (*)(bfd *)’ {aka ‘int (*)(struct bfd *)’} to ‘bfd_boolean (*)(bfd *, bfd *)’ {aka ‘int (*)(struct bfd *, struct bfd *)’}

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22823

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The master branch has been updated by Nick Clifton <address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=12ef3f5a7c5a6b89964842fd3da047b8d07dec91

commit 12ef3f5a7c5a6b89964842fd3da047b8d07dec91
Author: Nick Clifton <address@hidden>
Date:   Wed Feb 14 14:56:21 2018 +0000

    Fix compilation of the BFD sub-directory with a gcc v8 compiler by adding
extra casts.

    GCC v8 issues warnings about mis-matching casts of function pointers.
    A previous patch tried to fix this problem by adding new dummy functions
    which accepted a variable number of arguments.  But this introduces serious
    problems when compiled with other versions of gcc, (notably gcc 4.4).  This
    patch reverts that previous solution and instead adds extra casts (to
    function types without a parameter list).

    For more details see:
https://sourceware.org/ml/binutils/2018-02/msg00198.html

        PR 22823
        Revert previous delta.  Add extra casts to avoid compile time
        warnings instead.
        * libbfd-in.h (_bfd_generic_bfd_copy_private_bfd_data): Add extra
        cast to avoid warning from gcc v8 compiler.
        (_bfd_generic_bfd_merge_private_bfd_data): Likewise.
        (_bfd_generic_bfd_set_private_flags): Likewise.
        (_bfd_generic_bfd_copy_private_section_data): Likewise.
        (_bfd_generic_bfd_copy_private_symbol_data): Likewise.
        (_bfd_generic_bfd_copy_private_header_data): Likewise.
        (_bfd_generic_bfd_print_private_bfd_data): Likewise.
        (_bfd_noarchive_construct_extended_name_table): Likewise.
        (_bfd_noarchive_truncate_arname): Likewise.
        (_bfd_noarchive_write_ar_hdr): Likewise.
        (_bfd_noarchive_get_elt_at_index): Likewise.
        (_bfd_nosymbols_canonicalize_symtab): Likewise.
        (_bfd_nosymbols_print_symbol): Likewise.
        (_bfd_nosymbols_get_symbol_info): Likewise.
        (_bfd_nosymbols_get_symbol_version_string): Likewise.
        (_bfd_nosymbols_bfd_is_local_label_name): Likewise.
        (_bfd_nosymbols_bfd_is_target_special_symbol): Likewise.
        (_bfd_nosymbols_get_lineno): Likewise.
        (_bfd_nosymbols_find_nearest_line): Likewise.
        (_bfd_nosymbols_find_line): Likewise.
        (_bfd_nosymbols_find_inliner_info): Likewise.
        (_bfd_nosymbols_bfd_make_debug_symbol): Likewise.
        (_bfd_nosymbols_read_minisymbols): Likewise.
        (_bfd_nosymbols_minisymbol_to_symbol): Likewise.
        (_bfd_norelocs_bfd_reloc_type_lookup): Likewise.
        (_bfd_norelocs_bfd_reloc_name_lookup): Likewise.
        (_bfd_nowrite_set_arch_mach): Likewise.
        (_bfd_nowrite_set_section_contents): Likewise.
        (_bfd_nolink_sizeof_headers): Likewise.
        (_bfd_nolink_bfd_get_relocated_section_contents): Likewise.
        (_bfd_nolink_bfd_relax_section): Likewise.
        (_bfd_nolink_bfd_gc_sections): Likewise.
        (_bfd_nolink_bfd_lookup_section_flags): Likewise.
        (_bfd_nolink_bfd_merge_sections): Likewise.
        (_bfd_nolink_bfd_is_group_section): Likewise.
        (_bfd_nolink_bfd_discard_group): Likewise.
        (_bfd_nolink_bfd_link_hash_table_create): Likewise.
        (_bfd_nolink_bfd_link_add_symbols): Likewise.
        (_bfd_nolink_bfd_link_just_syms): Likewise.
        (_bfd_nolink_bfd_copy_link_hash_symbol_type): Likewise.
        (_bfd_nolink_bfd_final_link): Likewise.
        (_bfd_nolink_bfd_link_split_section): Likewise.
        (_bfd_nolink_section_already_linked): Likewise.
        (_bfd_nolink_bfd_define_common_symbol): Likewise.
        (_bfd_nolink_bfd_define_start_stop): Likewise.
        (_bfd_nodynamic_canonicalize_dynamic_symtab): Likewise.
        (_bfd_nodynamic_get_synthetic_symtab): Likewise.
        (_bfd_nodynamic_get_dynamic_reloc_upper_bound _bfd_): Likewise.
        (_bfd_nodynamic_canonicalize_dynamic_reloc): Likewise.
        * libbfd.c (bfd_false_any): Delete.
        (bfd_true_any, bfd_nullvoidptr_any, bfd_0_any): Delete.
        (bfd_0u_any, bfd_0l_any, _bfd_n1_any, bfd_void_any): Delete.
        * libbfd.h (extern): Regenerate
        * aout-target.h (MY_bfd_is_target_special_symbol): Add extra
        cast to avoid warning from gcc v8 compiler.
        * aout-tic30.c (tic30_aout_set_arch_mach): Likewise.
        * binary.c (binary_get_symbol_info): Likewise.
        * coff-alpha.c (alpha_ecoff_backend_data): Likewise.
        * coff-mips.c (mips_ecoff_backend_data): Likewise.
        * coffcode.h (coff_set_alignment_hook): Likewise.
        (symname_in_debug_hook): Likewise.
        (bfd_coff_backend_data bigobj_swap_table): Likewise.
        * elf-m10300.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-cr16.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-lm32.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-m32r.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-metag.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-score.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-score7.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-xstormy16.c (elf_backend_omit_section_dynsym): Likewise.
        * elf32-xtensa.c (elf_backend_omit_section_dynsym): Likewise.
        * elf64-alpha.c (elf_backend_omit_section_dynsym): Likewise.
        * elf64-hppa.c (elf_backend_omit_section_dynsym): Likewise.
        * elf64-ia64-vms.c (elf_backend_omit_section_dynsym): Likewise.
        * elf64-mmix.c (elf_backend_omit_section_dynsym): Likewise.
        * elf64-sh64.c (elf_backend_omit_section_dynsym): Likewise.
        * elfnn-ia64.c (elf_backend_omit_section_dynsym): Likewise.
        * elfxx-target.h (bfd_elfNN_bfd_debug_info_accumulate): Likewise.
        (bfd_elfNN_bfd_make_debug_symbol): Likewise.
        (bfd_elfNN_bfd_merge_private_bfd_data): Likewise.
        (bfd_elfNN_bfd_set_private_flags): Likewise.
        (bfd_elfNN_bfd_is_target_special_symbol): Likewise.
        (elf_backend_init_index_section): Likewise.
        (elf_backend_allow_non_load_phdr): Likewise.
        * elfxx-x86.h (elf_backend_omit_section_dynsym): Likewise.
        * i386msdos.c (msdos_bfd_is_target_special_symbol): Likewise.
        * ieee.c (ieee_construct_extended_name_table): Likewise.
        (ieee_write_armap): Likewise.
        (ieee_write_ar_hdr): Likewise.
        (ieee_bfd_is_target_special_symbol): Likewise.
        * ihex.c (ihex_canonicalize_symtab): Likewise.
        (ihex_bfd_is_target_special_symbol): Likewise.
        * libaout.h (aout_32_bfd_is_target_special_symbol): Likewise.
        * libecoff.h (_bfd_ecoff_bfd_is_target_special_symbol): Likewise.
        (_bfd_ecoff_set_alignment_hook): Likewise.
        * mach-o-target.c (bfd_mach_o_bfd_is_target_special_symbol): Likewise.
        * mmo.c (mmo_bfd_is_target_special_symbol): Likewise.
        * nlm-target.h (nlm_bfd_is_target_special_symbol): Likewise.
        * oasys.c (oasys_construct_extended_name_table): Likewise.
        (oasys_write_armap): Likewise.
        (oasys_write_ar_hdr): Likewise.
        (oasys_bfd_is_target_special_symbol): Likewise.
        * pef.c (bfd_pef_bfd_is_target_special_symbol): Likewise.
        * plugin.c (bfd_plugin_bfd_is_target_special_symbol): Likewise.
        * ppcboot.c (ppcboot_bfd_is_target_special_symbol): Likewise.
        * som.c (som_bfd_is_target_special_symbol): Likewise.
        * srec.c (srec_bfd_is_target_special_symbol): Likewise.
        * tekhex.c (tekhex_bfd_is_target_special_symbol): Likewise.
        * verilog.c (verilog_bfd_is_target_special_symbol): Likewise.
        * versados.c (versados_bfd_is_target_special_symbol): Likewise.
        (versados_bfd_reloc_name_lookup): Likewise.
        * vms-alpha.c (vms_bfd_is_target_special_symbol): Likewise.
        (vms_bfd_define_start_stop): Likewise.
        (alpha_vms_bfd_is_target_special_symbol): Likewise.
        * wasm-module.c (wasm_bfd_is_target_special_symbol): Likewise.
        * xsym.c (bfd_sym_bfd_is_target_special_symbol): Likewise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.