Re: DefineInGroup'd classes not really being defined?

[Andrew Stribblehill]

Quoting Chip Seraphine <address@hidden> (2003-05-13 15:20:39 BST):
> Excellent, thanks.  I had been confused about wether or not 
> AddInstallable was relevant since foo1 was being defined but not foo2.
> 
> So then does it make sense that foo2 was appearing in the CFALLCLASSES 
> even though it was not Installable?  Is that just a side effect of it 
> not being explicitly AddInstallable()'d, or is it the way things are 
> supposed to be? This kinda concerns me, because it means that my 
> shellouts might be seeing a different state than my cfengine script.

CFALLCLASSES gets constructed whenever it's needed, from VHEAP if
memory serves correctly. Even if a variable isn't marked as
installable, things can get put into VHEAP. This is certainly in the
category of "internal error" but might be worth adding a check to
AddClassToHeap anyway. So, somewhere near line 309 of eval.c put the
following:

   if (! IsItemIn(VALLADDCLASSES,class))
   {
      Warning("Internal software error: defining class that "
        "isn't installable");
   }

Feel free to upgrade that to FatalError :)

-- 
FAEROES
NORTH 6 OR 7 DECREASING 4 OR 5. RAIN OR SHOWERS. MODERATE OR GOOD