[Bug classpath/22832] [Swing] myTheme.addCustomEntriesToTable never called.

[gcc-bugzilla at gcc dot gnu dot org]

It would be really nice if classpath would call the
MetalTheme.addCustomEntriesToTable(UIDefaults table) after I do a
MetalLookAndFeel.setCurrentTheme(myMethalTheme);

Since the UIDefaults is created by the BasicLookAndFeel calling this should be
done in one of the (protected) init methods that the metalL&F can override.

Please note that the last set theme is the only one the customEntries should
end up in the UIDefaults for.  THis means you need to recreate the UIDefaults
with every theme change.


------- Comment #1 from from-classpath at savannah dot gnu dot org  2005-04-13 
14:19 -------
I am not sure if I think correctly, but IMO it would be completely sufficent to
add the custom entries to the UIDefaults table, because this would only
override the keys that the theme wants to override, and leave the rest in
place. If it is agreed that this would be correct, then the fix is trivial.


------- Comment #2 from from-classpath at savannah dot gnu dot org  2005-04-13 
15:05 -------
Roman;  that would probably miss the case where at time t1 a theme is set that
sets key A to a new value, and at time t2 another theme is set; which expects
key A to be the deault value.

Thomas


------- Comment #3 from from-classpath at savannah dot gnu dot org  2005-04-20 
13:47 -------
I have added a call to addCustomTableEntries in MetalLookAndFeel.getDefaults,
after all the init* methods have been called. This is correct AFAICS and after
what my mauve tests say.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22832