Raw pointers returned by public interface considered harmfull.

[Paul Elliott]

There are places in the public interface where raw pointers are
returned. This is bad. Raw pointers are an invitation to a memory
leak. Only experienced programmers should be allowed to use
raw pointers and then only carefully in private implementations.

Example: makeCommandOptionParse

If pointers must be returned, then some kind of managed pointer should
be used. But pointers are not proper objects and their use in a public
interface generally indicates some kind of design error, even apart
from safety concerns.


The public interface should be redone. Do it right next time.


-- 
Paul Elliott                       1(512)837-1096
address@hidden                    PMB 181, 11900 Metric Blvd Suite J
http://www.io.com/~pelliott/pme/   Austin TX 78758-3117

pgpU5w9faMTF7.pgp
Description: PGP signature