Re: du make check failure on Solaris 5.5 and 5.8 in coreutils-4.5.9

[Vin Shelton]

Jim,

Jim Meyering <address@hidden> writes:
> Vin Shelton <address@hidden> wrote:
>> In coreutils-4.5.9 on the Sparc Solaris machines at work, I'm getting
>> a 'make check' failure in the basic du test.  Here is the failure
>> under Solaris-5.5; as you can see the basic test fails:
>
> Hi Vin!
>
> Thank you for the report!
> Here's a patch:
>
>   http://mail.gnu.org/archive/html/bug-coreutils/2003-03/msg00046.html
>

Thanks for the speedy response, but the proposed patch didn't work.

Here's the diff of the two files (it's a pain trying to convert a
patch from HTML!), just to make sure:

--- lib/getcwd.c~       2003-03-05 03:18:28.000000000 -0500
+++ lib/getcwd.c        2003-03-11 11:03:16.258775000 -0500
@@ -32,10 +32,6 @@
 #include "pathmax.h"
 #include "same.h"
 
-/* Undefine getcwd here so any prototype is not redefined to be a
-   prototype for rpl_getcwd.  */
-#undef getcwd
-
 /* Guess high, because that makes the test below more conservative.
    But this is a kludge, because we should really use
    pathconf (".", _PC_NAME_MAX).  But it's probably not worth the cost.  */
@@ -43,6 +39,14 @@
 
 #define MAX_SAFE_LEN (PATH_MAX - 1 - KLUDGE_POSIX_NAME_MAX - 1)
 
+/* Undefine getcwd here, as near the use as possible, in case any
+   of the files included above define it to rpl_getcwd.  */
+#undef getcwd
+
+/* Any declaration of getcwd from headers included above has
+   been changed to a declaration of rpl_getcwd.  Declare it here.  */
+extern char *getcwd (char *buf, size_t size);
+ 
 /* This is a wrapper for getcwd.
    Some implementations (at least GNU libc 2.3.1 + linux-2.4.20) return
    non-NULL for a working directory name longer than PATH_MAX, yet the


and here are the results of running the basic test on du (after
reconfiguring [just to be sure] and recompiling)

make  check-TESTS
make[1]: Entering directory 
`/u/shelton2/software/build/SunOS-5.5/coreutils-4.5.9/tests/du'
+ du --version 
du (coreutils) 4.5.9
Written by Torbjorn Granlund, David MacKenzie, Larry McVoy, Paul Eggert, and 
Jim Meyering.

Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ . ../../../../../src/coreutils-4.5.9/tests/du/../envvar-check 
as_unset=unset
+ unset VERSION_CONTROL SIMPLE_BACKUP_SUFFIX 
+ unset BLOCK_SIZE DU_BLOCK_SIZE DF_BLOCK_SIZE LS_BLOCK_SIZE 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = 1 
+ pwd 
pwd=/u/shelton2/software/build/SunOS-5.5/coreutils-4.5.9/tests/du
+ echo ../../../../../src/coreutils-4.5.9/tests/du/8gb 
+ sed s,.*/,, 
t0=8gb.tmp
tmp=8gb.tmp/19681
+ trap status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit $status 0 
+ trap (exit $?); exit $? 1 2 13 15 
framework_failure=0
+ mkdir -p 8gb.tmp/19681 
+ cd 8gb.tmp/19681 
+ test 0 = 1 
+ dd bs=1 seek=8G of=big 
+ test 1 != 0 
+ echo ../../../../../src/coreutils-4.5.9/tests/du/8gb: cannot create a file 
large enough for this test; possibly 
../../../../../src/coreutils-4.5.9/tests/du/8gb: cannot create a file large 
enough for this test; possibly
+ echo ../../../../../src/coreutils-4.5.9/tests/du/8gb: because file offsets 
are only 32 bits on this file system 
../../../../../src/coreutils-4.5.9/tests/du/8gb: because file offsets are only 
32 bits on this file system
+ exit 77 
+ exit 77 
status=77
+ cd /u/shelton2/software/build/SunOS-5.5/coreutils-4.5.9/tests/du 
+ chmod -R u+rwx 8gb.tmp 
+ rm -rf 8gb.tmp 
+ exit 77 
SKIP: 8gb
+ du --version 
du (coreutils) 4.5.9
Written by Torbjorn Granlund, David MacKenzie, Larry McVoy, Paul Eggert, and 
Jim Meyering.

Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ . ../../../../../src/coreutils-4.5.9/tests/du/../envvar-check 
as_unset=unset
+ unset VERSION_CONTROL SIMPLE_BACKUP_SUFFIX 
+ unset BLOCK_SIZE DU_BLOCK_SIZE DF_BLOCK_SIZE LS_BLOCK_SIZE 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = set 
+ test  = 1 
+ pwd 
pwd=/u/shelton2/software/build/SunOS-5.5/coreutils-4.5.9/tests/du
+ echo ../../../../../src/coreutils-4.5.9/tests/du/basic 
+ sed s,.*/,, 
t0=basic.tmp
tmp=basic.tmp/19693
+ trap status=$?; cd $pwd; chmod -R u+rwx $t0; rm -rf $t0 && exit $status 0 
+ trap (exit $?); exit $? 1 2 13 15 
framework_failure=0
+ mkdir -p basic.tmp/19693 
+ cd basic.tmp/19693 
+ mkdir -p a/b 
+ printf make-sure-the-file-is-non-empty\n 
+ test 0 = 1 
+ stat --format=%bx%B a 
+ test 8x512 != 8x512 
fail=0
+ du -a a 
+ echo === 
+ du -aS a 
+ echo === 
+ du -s a 
+ cat 
+ cmp out exp 
out exp differ: char 1, line 1
fail=1
+ test 1 = 1 
+ diff out exp 
1,3c1,3
< 0     a/b/c
< 4     a/b
< 8     a
---
> 4     a/b/c
> 8     a/b
> 12    a
5c5
< 0     a/b/c
---
> 4     a/b/c
9c9
< 8     a
---
> 12    a
+ exit 1 
+ exit 1 
status=1
+ cd /u/shelton2/software/build/SunOS-5.5/coreutils-4.5.9/tests/du 
+ chmod -R u+rwx basic.tmp 
+ rm -rf basic.tmp 
+ exit 1 
FAIL: basic

HTH,
  Vin

-- 
In a minute there is time
For decisions and revisions which a minute will reverse.         T.S. Eliot
[URL: http://www.cs.amherst.edu/~ccm/prufrock.html]