[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: coreutils-6.0 on BeOS (1)
From: |
Jim Meyering |
Subject: |
Re: coreutils-6.0 on BeOS (1) |
Date: |
Tue, 22 Aug 2006 12:13:28 +0200 |
Bruno Haible <address@hidden> wrote:
> On BeOS 5, building coreutils shows, apart from the c89-c99 and the gzip
> --help
> issue (which have already been handled), a number of minor compilation
> failures.
...
> a "make check" attempts to builds the programs
> chroot - and fails because BeOS has no chroot() function,
> df - that compiles,
...
> nice - fails because BeOS has no nice() or getpriority() function,
> su - that compiles but is pointless,
> pinky, uptime, users, who - fail because BeOS has no <utmp.h> nor <utmpx.h>.
>
> The 'check' target depends on 'check-AUTHORS'.
> 'check-AUTHORS' depends on $(all_programs).
> $(all_programs) includes $(EXTRA_PROGRAMS).
Hi Bruno,
Thanks for the report and patch.
I've moved that rule to "make distcheck" instead:
2006-08-22 Jim Meyering <address@hidden>
Move the check-AUTHORS rule to be run as part of "make distcheck",
rather than "make check".
* src/Makefile.am (check): Don't depend on check-AUTHORS; it would
cause "make check" to fail on systems unable to build all binaries.
* Makefile.maint (check-AUTHORS): New rule.
(local-checks-available): Add it here.
Reported by Bruno Haible. Needed for BeOS.
Index: src/Makefile.am
===================================================================
RCS file: /fetish/cu/src/Makefile.am,v
retrieving revision 1.71
diff -u -r1.71 Makefile.am
--- src/Makefile.am 8 Aug 2006 22:19:03 -0000 1.71
+++ src/Makefile.am 22 Aug 2006 09:47:09 -0000
@@ -267,7 +267,7 @@
pr = progs-readme
# Ensure that the list of programs in README matches the list
# of programs we can build.
-check: check-README check-misc check-AUTHORS
+check: check-README check-misc
.PHONY: check-README
check-README:
rm -rf $(pr) $(pm)
Index: Makefile.maint
===================================================================
RCS file: /fetish/cu/Makefile.maint,v
retrieving revision 1.245
diff -u -r1.245 Makefile.maint
--- Makefile.maint 17 Aug 2006 10:03:05 -0000 1.245
+++ Makefile.maint 22 Aug 2006 09:48:43 -0000
@@ -74,7 +74,7 @@
po-check copyright-check writable-files m4-check author_mark_check \
changelog-check patch-check strftime-check $(syntax-check-rules) \
makefile_path_separator_check \
- makefile-check
+ makefile-check check-AUTHORS
.PHONY: $(local-checks-available)
local-check = $(filter-out $(local-checks-to-skip), $(local-checks-available))
@@ -308,6 +308,9 @@
rm -f address@hidden address@hidden;
\
fi
+check-AUTHORS:
+ $(MAKE) -C src $@
+
# Ensure that we use only the standard $(VAR) notation,
# not @...@ in Makefile.am, now that we can rely on automake
# to emit a definition for each substituted variable.