|
From: | mwoehlke |
Subject: | Re: coreutils-6.1: needs 'ls' patch (bug #15043) |
Date: | Mon, 28 Aug 2006 16:02:48 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060719 Thunderbird/1.5.0.5 Mnenhy/0.7.4.0 |
Jim Meyering wrote:
Jim Meyering <address@hidden> wrote:mwoehlke <address@hidden> wrote:Mike Frysinger wrote:On Thursday 24 August 2006 17:03, mwoehlke wrote:https://savannah.gnu.org/bugs/?func=detailitem&item_id=15043 Is this going to get fixed, or what? There is a trivial fix available, it just needs someone that knows how to make it 'Linux-only'.#if __linux__ <foo> #endif -mikeOk, thanks. I a: wasn't sure of a macro that would be defined on Linux (is there a list of these things anywhere? Preferably covering most major platforms?), and b: wasn't sure if people here appreciated such patches. If #ifdef is OK, this should do it (works for me with 5.97 and 6.1):Thanks for pursuing that. No #ifdef needed. Here's the patch I'll probably commit (destined for the trunk):I've checked this in on the trunk: [snip changelog]
Thanks, although as noted elsewhere in this thread I still would have made it '#ifdef linux'. At any rate, it will work on Linux, and if it does extra work elsewhere, well, I can live with that. :-)
-- Matthew We are Microsoft. You will be assimilated. Resistance is futile. --Badtech
[Prev in Thread] | Current Thread | [Next in Thread] |