[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GNU_PACKAGE vs. PACKAGE_NAME
From: |
Jim Meyering |
Subject: |
Re: GNU_PACKAGE vs. PACKAGE_NAME |
Date: |
Thu, 30 Aug 2007 16:59:55 +0200 |
Eric Blake-1 <address@hidden> wrote:
> This reduces the size of configure and the generated
> config.h a bit, by using autoconf's PACKAGE_NAME
> rather than a hand-rolled GNU_PACKAGE expanding to
> the same string.
>
> I did not alter whether the package name should be
> "GNU coreutils" (the current name) or "GNU Coreutils"
> (more in line with other GNU packages, to capitalize
> the package name). It is a one-line change to
> configure.ac AC_INIT, but I wasn't sure whether the
> testsuite would be impacted by it.
>
> Also, I think it is worth considering a testsuite addition
> to ensure the equivalent of:
> diff <(id --version | sed '/^$/q') \
> <(groups --version | sed 's/^groups/id/; /^$/q')
> succeeds, but did not do it in this patch.
>
> There are a number of other things that can be
> trimmed out of configure.ac and its helper input
> files, either because they are obsolete according to
> autoconf, or because they are already picked up by
> gnulib, but I stopped here before making the patch
> too big to review.
Thanks!
I'm applying it to take a look.
Hmm... FYI, something (your mail client?) corrupted that patch
by breaking some long lines. about 6 of them. I've adjusted manually,
and will review later today.
Re: GNU_PACKAGE vs. PACKAGE_NAME, Jim Meyering, 2007/08/30