Re: coreutils-6.9.91 released (bug-fix-only)

[Jim Meyering]

Bauke Jan Douma <address@hidden> wrote:
> I just got around to building this yesterday. Without having much time
> to devote to testing, I noted a few minor things.

Thanks for the testing and report.

There has been so little feedback that I wonder
how many people actually build test releases.

> ./configure \
> --disable-assert \
> --enable-no-install-program="groups id kill su uptime hostname arch"
>
> configure --help sez:
> #   --enable-no-install-program=PROG_LIST
> #                           do NOT install the programs in PROG_LIST
> #                           (comma-separated, default: arch hostname su)
>
> I think the latter should be changed into:
>       (comma-separated, default: arch,hostname,su)
> I initially built having spaces instead of comma's.

Yes, I think so, too.
I've adjusted it.

> $> RUN_EXPENSIVE_TESTS=1 make -k check
>
> First time around I got two fails running this:
>
> FAIL: groups-version.log

I've arranged to skip this test if groups or id is not being built,
but in general, I'm not trying to allow for any combination of
programs not to be installed.

> FAIL: preserve-gid.log

You must have run "make check" as root, I suppose.
Otherwise, this test is skipped.
...
> FAIL: preserve-gid.log (exit: 1)
> ================================
> cp: cannot open `a0' for reading: Permission denied
...
> FAIL: test-getaddrinfo
>
> I think this latter run must have been while being offline.

That would explain it.
Here are the three patches I've just pushed:

>From 8ddc5056f21039a319a65bece258eccf479e35f8 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 20 Dec 2007 14:03:12 +0100
Subject: [PATCH] Avoid spurious "make check" failures due to omitted programs.

* man/Makefile.am (distcheck-hook): Make check rules dependents of
this target, not of check-local, so that people aren't distracted by
failures due to programs omitted via --enable-no-install-program=...

Signed-off-by: Jim Meyering <address@hidden>
---
 ChangeLog       |    7 +++++++
 man/Makefile.am |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index df016fa..427f78e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2007-12-20  Jim Meyering  <address@hidden>
+
+       Avoid spurious "make check" failures due to omitted programs.
+       * man/Makefile.am (distcheck-hook): Make check rules dependents of
+       this target, not of check-local, so that people aren't distracted by
+       failures due to programs omitted via --enable-no-install-program=...
+
 2007-12-19  Paul Eggert  <address@hidden>

        * src/uniq.c (usage): Improve wording in --help "Note".
diff --git a/man/Makefile.am b/man/Makefile.am
index 8d1f7f7..b7b960e 100644
--- a/man/Makefile.am
+++ b/man/Makefile.am
@@ -163,7 +163,7 @@ mapped_name = `echo $*|sed 's/^install$$/ginstall/; 
s/^test$$/[/'`
            && rm -rf $t ;;                                     \
        esac

-check-local: check-x-vs-1 check-programs-vs-x
+distcheck-hook: check-x-vs-1 check-programs-vs-x

 # Sort in traditional ASCII order, regardless of the current locale;
 # otherwise we may get into trouble with distinct strings that the
--
1.5.4.rc0.76.g55ee


>From 2fc00bda8c6aaab5d0478cc54cf78260090ba74c Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 20 Dec 2007 14:19:56 +0100
Subject: [PATCH] Avoid another "make check" failure due to omitted programs.

* tests/test-lib.sh (require_built_): New function.
* tests/misc/groups-version: Use it to skip this test if
either groups or id is not built.

Signed-off-by: Jim Meyering <address@hidden>
---
 ChangeLog                 |    5 +++++
 tests/misc/groups-version |    1 +
 tests/test-lib.sh         |   13 +++++++++++++
 3 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 427f78e..412f13a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2007-12-20  Jim Meyering  <address@hidden>

+       Avoid another "make check" failure due to omitted programs.
+       * tests/test-lib.sh (require_built_): New function.
+       * tests/misc/groups-version: Use it to skip this test if
+       either groups or id is not built.
+
        Avoid spurious "make check" failures due to omitted programs.
        * man/Makefile.am (distcheck-hook): Make check rules dependents of
        this target, not of check-local, so that people aren't distracted by
diff --git a/tests/misc/groups-version b/tests/misc/groups-version
index 15327be..e7050c3 100755
--- a/tests/misc/groups-version
+++ b/tests/misc/groups-version
@@ -23,6 +23,7 @@ fi

 . $srcdir/../lang-default
 . $srcdir/../test-lib.sh
+require_built_ groups id

 fail=0
 groups --version | sed 's/^groups/id/; /^$/q' > out || fail=1
diff --git a/tests/test-lib.sh b/tests/test-lib.sh
index 8872b27..a3afba0 100644
--- a/tests/test-lib.sh
+++ b/tests/test-lib.sh
@@ -29,6 +29,19 @@ require_ulimit_()
     && skip_test_ "this shell lacks ulimit support"
 }

+require_built_()
+{
+  skip_=no
+  for i in "$@"; do
+    case " $built_programs " in
+      *" $i "*) ;;
+      *) echo "$i: not built" 1>&2; skip_=yes ;;
+    esac
+  done
+
+  test $skip_ = yes && skip_test_ "required program(s) not built"
+}
+
 uid_is_privileged_()
 {
   # Make sure id -u succeeds.
--
1.5.4.rc0.76.g55ee


>From c3cac089b1e6cc5c8f29ddad5c52002ac5bf34c8 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 20 Dec 2007 17:38:57 +0100
Subject: [PATCH] Use comma-separated list in ./configure --help output.

* configure.ac: Map commas to spaces in excluded-program list.
Use a comma-separated list, not a space-separated one.
* m4/include-exclude-prog.m4 (gl_INCLUDE_EXCLUDE_PROG):
Expect list of program names to be comma-separated.
Reported by Jan Bauke Douma.

Signed-off-by: Jim Meyering <address@hidden>
---
 ChangeLog                  |    7 +++++++
 configure.ac               |    9 ++++++---
 m4/include-exclude-prog.m4 |    5 +++--
 3 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 412f13a..7273199 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2007-12-20  Jim Meyering  <address@hidden>

+       Use comma-separated list in ./configure --help output.
+       * configure.ac: Map commas to spaces in excluded-program list.
+       Use a comma-separated list, not a space-separated one.
+       * m4/include-exclude-prog.m4 (gl_INCLUDE_EXCLUDE_PROG):
+       Expect list of program names to be comma-separated.
+       Reported by Jan Bauke Douma.
+
        Avoid another "make check" failure due to omitted programs.
        * tests/test-lib.sh (require_built_): New function.
        * tests/misc/groups-version: Use it to skip this test if
diff --git a/configure.ac b/configure.ac
index 6d996de..78c662a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -279,12 +279,12 @@ no_install_progs_default=`echo "$t"|sed 's/ $//'`
 # The compromise is to ensure that the space-separated list extracted
 # above matches the literal 2nd argument below.
 c="$srcdir/configure.ac"
-t=`sed -n '/^g''l_INCLUDE_EXCLUDE_PROG(.* [\[\(.*\)\]])/s//\1/p' $c`
+t=`sed -n '/^g''l_INCLUDE_EXCLUDE_PROG(.* [\[\(.*\)\]])/{s//\1/;s/,/ /gp}' $c`
 case $t in
   $no_install_progs_default) ;;
   *) AC_MSG_ERROR([[internal error: g'l_INCLUDE_EXCLUDE_PROG's 2nd arg, $t,
                    does not match the list of default-not-installed programs
-                  ($no_install_progs_default) extracted also recorded in $mk]],
+                  ($no_install_progs_default) also recorded in $mk]],
                   1) ;;
 esac

@@ -294,7 +294,10 @@ esac
 # "don't-install" requests.
 # I.e., add any program name specified via --enable-install-program=..., and
 # remove any program name specified via --enable-no-install-program=...
-gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch hostname su])
+# Note how the second argument below is a literal, with "," separators.
+# That is required due to the way the macro works, and since the
+# corresponding ./configure option argument is comma-separated on input.
+gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch,hostname,su])

 # Set INSTALL_SU if su installation has been requested via
 # --enable-install-program=su.
diff --git a/m4/include-exclude-prog.m4 b/m4/include-exclude-prog.m4
index c5e31d9..cf11c78 100644
--- a/m4/include-exclude-prog.m4
+++ b/m4/include-exclude-prog.m4
@@ -27,12 +27,13 @@ AC_DEFUN([gl_REMOVE_PROG],
 # Given the name of a variable containing a space-separated list of
 # install-by-default programs and the list of do-not-install-by-default
 # programs, modify the former variable to reflect "no-install" and
-# "do-install" requests.
+# "do-install" requests.  The names in the latter list should be comma-
+# separated.
 #
 # Usage: gl_INCLUDE_EXCLUDE_PROG([prog_list_var_name], [no_inst_prog_list])
 AC_DEFUN([gl_INCLUDE_EXCLUDE_PROG],
 [{
-  gl_no_install_progs_default='$2'
+  gl_no_install_progs_default=`echo '$2'|sed 's/,/ /g'`
   AC_ARG_ENABLE([install-program],
     [AS_HELP_STRING([--enable-install-program=PROG_LIST],
                    [install the programs in PROG_LIST (comma-separated,
--
1.5.4.rc0.76.g55ee