bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use getgrouplist where available.


From: Jim Meyering
Subject: Re: [PATCH] Use getgrouplist where available.
Date: Fri, 22 Feb 2008 10:27:59 +0100

"James Youngman" <address@hidden> wrote:
> On Fri, Feb 22, 2008 at 9:04 AM, Jim Meyering <address@hidden> wrote:
...
>>  +         h = realloc (g, max_n_groups * sizeof *h);
>
> Shouldn't realloc here be xnrealloc?

No.  This function is intended to be usable from a library.
I.e., no fair calling exit, which xnrealloc does when it fails.

Also, the function header comment says what happens
when it fails, and "exit" is not mentioned.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]