Re: [PATCH] dd - support for reading of full blocks

[Kamil Dudka]

On Friday 18 July 2008 03:54:41 pm you wrote:
> As for the new name, iflag=block would be my preference if it weren't
> for the existence of conv=block/unblock and iflag=nonblock.  Too much
> room for misunderstanding.
>
> I'd be happy with either of the following, with a slight preference for
> the first (it's shorter and doesn't need the "read" prefix to indicate
> that it affects only how input is read):
>
>     iflag=fullblock
>     conv=readfullblock
Ok, changed to iflag=fullblock - new patch in attachment.

> Kamil, with new features, it is customary to write tests
> to exercise the new functionality.  One way would be
> to do something like this, but appending the new option
>
>     $ (echo a; sleep .1; echo b) \
>
>       | dd conv=block cbs=5 status=noxfer > out 2> err
>
> and then comparing "out" and "err" against expected outputs.
Ok, test added to dd/misc. Thank you for advice.

Kamil

coreutils-dd-fullblock.patch
Description: Text Data