Re: rm -rf: avoid ext3/4 O(N^2) performance hit, further librarify remove.c

[Jim Meyering]

Ralf Wildenhues <address@hidden> wrote:
> Hello Jim, a tiny nit again:
>
> Jim Meyering <jim <at> meyering.net> writes:
>> +/* A comparison function to sort on increasing inode number.  */
>> +static int
>> +compare_ino (void const *av, void const *bv)
>> +{
>> +  struct readdir_data const *const *a = av;
>> +  struct readdir_data const *const *b = bv;
>> +  return a[0]->ino - b[0]->ino;
>> +}
>
> Susceptible to integer overflow, like the gnulib code.

Yes.  Thanks again.